ClassNotFoundException when using SafeArgs with Proguard and Navigation Architecture Component?

Question

I'm using SafeArgs plugin and Navigation Architecture Component but the app is crashing.

Caused by: java.lang.ClassNotFoundException: Didn't find class "com.package.domain.models.Model"

I'm using minifyEnabled true in the Gradle.

Also, I have three modules app, data, and domain. So, in all three proguard-rules files I have added

-keepnames class com.package.domain.models.Model1
-keepnames class com.package.domain.types.ImageType
-keepnames class com.package.domain.models.Model

I'm using these three classes as argType in my Navigation graph.

But the app is still crashing. Any help would be appreciated.

Is it ok when minifyEnabled false? – hata Apr 22 '21 at 00:14 — hata, Apr 22 '21 at 00:14
@hata yeah it is fine. – OhhhThatVarun Apr 22 '21 at 03:33 — OhhhThatVarun, Apr 22 '21 at 03:33
Which version are you using? – Róbert Nagy Apr 22 '21 at 09:58 — Róbert Nagy, Apr 22 '21 at 09:58
@RobertNagy version of? – OhhhThatVarun Apr 22 '21 at 11:14 — OhhhThatVarun, Apr 22 '21 at 11:14
@hata yes it is okay with `minifyEnabled false` – OhhhThatVarun Apr 29 '21 at 05:22 — OhhhThatVarun, Apr 29 '21 at 05:22

score 11 · Accepted Answer · answered Apr 29 '21 at 05:21

11

I think the more appropriate thing to do would be adding this to add these in my proguard-rules file(s).

-keepnames class * extends android.os.Parcelable
-keepnames class * extends java.io.Serializable

As I don't have to keep annotating my models with @Keep which are Parcelable or Serializable or keeping the whole model package away from obfuscation.

Check this for more information.

answered Apr 29 '21 at 05:21

OhhhThatVarun

3,981
2
26
49

Is there a reason why you use the "extends" qualifier instead of "implements"? Either way from what I found they should be equivalent I guess: https://www.guardsquare.com/manual/configuration/usage#classspecification – G00fY Sep 06 '22 at 19:18

score 2 · Answer 2 · answered Apr 22 '21 at 09:54

2

Try with putting @Keep annotation top of class. Like

import androidx.annotation.Keep

@Keep
data class RepoData(val id: Long, val name: String)

answered Apr 22 '21 at 09:54

NRUSINGHA MOHARANA

1,489
8
13

1

Thank you! but I think this answers my question better. https://stackoverflow.com/a/50378828/7436566 – OhhhThatVarun Apr 28 '21 at 10:05

score 0 · Answer 3 · answered Apr 22 '21 at 18:52

0

You can keep the whole model package (it's usually alright to do it actually) like

-keep class com.package.domain.models.** { *; }

answered Apr 22 '21 at 18:52

Amin

3,056
4
23
34

Thank you! but I think this answers my question better. https://stackoverflow.com/a/50378828/7436566 – OhhhThatVarun Apr 28 '21 at 10:04

score -1 · Answer 4 · answered Apr 28 '21 at 09:49

-1

Always use @keep annotation whenever you want the class to stay in memory .

@Keep data class MyData(val id: long,val name: String)

answered Apr 28 '21 at 09:49

Sumeet kishore

19
4

Thank you! but I think this answers my question better. https://stackoverflow.com/a/50378828/7436566 – OhhhThatVarun Apr 28 '21 at 10:04

ClassNotFoundException when using SafeArgs with Proguard and Navigation Architecture Component?

4 Answers4

Linked