Can not Insert data into MySQL from PHP form

Question

After I fill up the PHP form, the data is not showing in mysql. What is wrong with my code and how can i fix it?

These are all my codes. Please help me I am still a beginner in php. I tried searching my error in other websites however it is not working.

This is the code for the form index.php

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
</head>
<body>
  <!-- C R E A T E  D A T A -->
  <form class="" action="createdatatry.php" method="post">
    <h3>ENTER THE FOLLOWING SUPPLIER INFORMATION:</h3>
    <input type="text" name="Supplier_Name" placeholder="Enter Supplier Name" required/>
    <input type="text" name="Supplier_Contact" placeholder="Enter Contact No." required/>
    <input type="text" name="Supplier_StreetNo" placeholder="Enter Street No." required/>
    <input type="text" name="Supplier_Province" placeholder="Enter Province" required/>
    <input type="text" name="Supplier_PostalCode" placeholder="Enter Postal Code" required/>
    <input type="text" name="Supplier_Country" placeholder="Enter Country" required/>
    <input type="submit" name="create" value="CREATE">
  </form>
</body>
</html>

This is the code for the mysql connection database.php

<?php
    
$host = 'localhost';
$user = 'root';
$password = '';
$database = 'sourcingdb';

$connection = mysqli_connect($host, $user, $password, $database);

if (mysqli_connect_error()) {
    echo "Error Unable to connect to MySQL server <br>";
    echo "Message: ".mysqli_connect_error()."<br>";
} 


?>

This is the code in creating/ inserting data into mysql createdatatry.php

<?php

require('./database.php');

if (isset($_POST['create'])) {
    $Supplier_Name = $_POST['Supplier_Name'];
    $Supplier_Contact = $_POST['Supplier_Contact'];
    $Supplier_StreetNo = $_POST['Supplier_StreetNo'];
    $Supplier_Prov = $_POST['Supplier_Prov'];
    $Supplier_PostalCode = $_POST['Supplier_PostalCode'];
    $Supplier_Country = $_POST['Supplier_Country'];

    $queryCreate = "INSERT INTO supplierinfo (`Supplier_Name`, `Supplier_Contact`, `Supplier_StreetNo`, `Supplier_Province`, `Supplier_PostalCode`, `Supplier_Country`) VALUES ('$Supplier_name', '$Supplier_Contact', '$Supplier_StreetNo', '$Supplier_Prov', '$Supplier_PostalCode', '$Supplier_ountry')";
    $sqlCreate = mysqli_query($connection, $queryCreate);

    echo '<script>alert("Successfully created!")</script>';
    //echo '<script>window.location.href = "/sourcing/index.php"</script>';
}

?>

If you're just starting out, avoid learning bad habits. Use PDO and prepared statements, not mysqli and substituting variables directly into SQL. — Barmar, May 04 '21 at 04:18
oh I typed it wrong, Instead of createdata.php, it's createdatatry.php — Carrington, May 04 '21 at 04:18
What is wrong with my code how come the data is not showing in mysql. — Carrington, May 04 '21 at 04:19
I don't see any obvious problems. Like I said, add error checking. — Barmar, May 04 '21 at 04:22
yes I am getting the "Successfully alert" after I fill up the php form — Carrington, May 04 '21 at 04:34
See https://stackoverflow.com/questions/22662488/mysqli-fetch-assoc-expects-parameter-call-to-a-member-function-bind-param for how to get mysqli errors. — Barmar, May 04 '21 at 04:36

score 0 · Answer 1 · answered May 04 '21 at 09:56

0

Problem solved: Apparently, I did not check the structure of my table (ex. data types) that is why the data is not visible in mysql.

answered May 04 '21 at 09:56

Carrington

7
2

Rohit Kanojiya · Answer 2 · 2021-05-04T04:20:31.177

-1

You have given wrong file name in forms action on index.php

You have to write action="createdata.php" in form on index.php

edited May 04 '21 at 04:20

answered May 04 '21 at 04:19

Rohit Kanojiya

11
6

He already responded to a comment saying that he wrote the wrong filename here. – Barmar May 04 '21 at 04:20
it supposed to be createdatatry.php not createdata.php. I typed it wrong in my question – Carrington May 04 '21 at 04:32
Please share more details to your answer such that others can learn from it. Wouldn't that throw a pretty obvious 404 error? – Nico Haase May 04 '21 at 10:00

score -1 · Answer 3 · answered May 04 '21 at 04:26

-1

Form action should be like this :

form action = "createdata.php" method="POST"

Your query should be like this :

$queryCreate = "INSERT INTO supplierinfo (Supplier_Name, Supplier_Contact, Supplier_StreetNo, Supplier_Province, Supplier_PostalCode, Supplier_Country) VALUES ('$Supplier_name', '$Supplier_Contact', '$Supplier_StreetNo', '$Supplier_Prov', '$Supplier_PostalCode', '$Supplier_Country')";

answered May 04 '21 at 04:26

Vincent

1
3

i tried this but the data is still not visible in mysql :( – Carrington May 04 '21 at 04:34
What do you mean by "like this"? That's still highly vulnerable code that should **never** be used – Nico Haase May 04 '21 at 09:59

score -1 · Answer 4 · answered May 04 '21 at 06:15

-1

For your query

$queryCreate = "INSERT INTO supplierinfo (`Supplier_Name`, `Supplier_Contact`, `Supplier_StreetNo`, `Supplier_Province`, `Supplier_PostalCode`, `Supplier_Country`) VALUES ('$Supplier_name', '$Supplier_Contact', '$Supplier_StreetNo', '$Supplier_Prov', '$Supplier_PostalCode', '$Supplier_ountry')";

    $sqlCreate = mysqli_query($connection, $queryCreate);

You only assigned mysqli_query($connection, $queryCreate) to a PHP variable , but you didnt execute it.

Try this

if(mysqli_query($connection, $queryCreate)){
  echo '<script>alert("Successfully created!")</script>';
}

answered May 04 '21 at 06:15

Steve Kush

143
1
13

By all means , this is a nested if else statement in your if(isset) statement. – Steve Kush May 04 '21 at 06:16
I tried this however, what does it mean if "successfully created" is not showing after I fill up the form? – Carrington May 04 '21 at 06:44
Then it will be the sql query problem. Does your console show any errors ? – Steve Kush May 04 '21 at 06:52
No it does not show anything, what do you mean by sql query problem is that the "INSERT INTO" part? – Carrington May 04 '21 at 07:08
Yes, however i am not familair with mysql so thats all i can help sadly. – Steve Kush May 04 '21 at 07:11
Please try out the solutions from here https://www.w3schools.com/php/php_mysql_insert.asp – Steve Kush May 04 '21 at 07:14
Please add some explanation to your answer such that others can learn from it. Calling `mysqli_query` **will** execute the query – Nico Haase May 04 '21 at 09:59

Can not Insert data into MySQL from PHP form

4 Answers4