C# Maintain 3 threads and close one if it takes to long

Question

This is the code I am using to call 3 threads.

for (int i = 0; i < 3; i++)
{
    new Thread(() => { processEventLogTesting(); }) {IsBackground = true }.Start();
}

I was thinking about adjusting it to this

public static int ThreadCounter = 0;

if (ThreadCounter < 3)
{
    ThreadCounter ++;
    for (int i = 0; i < 3; i++)
    {
        new Thread(() => 
        {
            processEventLogTesting(/*somewhere in here code says */ThreadCounter--;);}) {IsBackground = true }.Start();
        }
    }
}

However, I think this is probably not the best way to do this. Also, I want to put in a new timer that says if thread x goes over 20 minutes, kill thread x. Any help is appreciated.

Careful with that axe, Eugene. What you are trying to do is *super dangerous*. Write your code so that it shuts itself down cleanly; do not abort the thread. See http://blogs.msdn.com/b/ericlippert/archive/2010/02/22/should-i-specify-a-timeout.aspx for more details. — Eric Lippert, Jul 20 '11 at 21:38

Marin · Accepted Answer · 2011-07-20T21:54:08.703

Since I don't know what thread does, I would try something like this

        private Object lockObject = new Object();
        private int threadCounter = 0;
        public int ThreadCounter
        {
            get
            {
                lock(lockObject)
                { 
                    return threadCounter;
                } 
            }            
            set
            {
                lock(lockObject)
                { 
                    threadCounter = value;
                } 
            }
        }

        //this should be a method
        if (ThreadCounter < 3)
        {
            ThreadCounter ++;
            new Thread(() => 
            {
                Timer t = new Timer(() => EndThread(), null, 0, 20 * 60 * 1000);
                while(threadIsRunning)
                {                     
                     processEventLogTesting(/*somewhere in here code says ThreadCounter--*/;);
                }
            }) {IsBackground = true }.Start();

                }
            }
        }

        private void EndThread()
        {
            threadIsRunning = false;
        }

This won't actually end the threads if processEventLogTesting is hung. You need to call Thread.Abort for that. — Ed Bayiates, Jul 20 '11 at 21:50
@AresAvatar Thread.Abort is dangerous to use and should only be used as last resort — Marin, Jul 20 '11 at 21:58
Yes -- as a last resort. The OP did not provide the internals of his function. — Ed Bayiates, Jul 20 '11 at 22:00

C# Maintain 3 threads and close one if it takes to long

1 Answers1