Change variable in .then promise

Asked Jun 21 '21 at 19:00

Active Jun 21 '21 at 19:00

Viewed 14 times

can someone tell me how to change the variable. I have recognized that it doesn't work this way but I don't know how I can fix this.

          var superhero;
          function fetchSuperhero() {
            fetch('https://mdn.github.io/learning-area/javascript/oojs/json/superheroes.json')
            .then((response) => {
              return response.json()
            })
            .then((data) => {
              console.log(data)
              var heroes = data.members;
              var i = Math.floor((Math.random() * heroes.length) + 1);
              superhero = heroes[i].name;
            })
            .catch((err) => {
              console.log("error");
            })
          }

asked Jun 21 '21 at 19:00

OuttaNowhere

You're changing the variable just fine. You're probably accessing it before it will have changed, though - but you haven't shown us that part of the code where you attempt to use `superhero`. – Bergi Jun 21 '21 at 19:05
Also drop the `+1` from the calculation of the random index. – Bergi Jun 21 '21 at 19:06
@Bergi I want to add superhero to a Json object. `code` fetchSuperhero(); jsonObject.superhero = superhero – OuttaNowhere Jun 21 '21 at 20:01
Do that inside the `then` callback, so that the code runs when the json is actually loaded. – Bergi Jun 21 '21 at 20:15
When I try this it still says that superhero is undefined – OuttaNowhere Jun 21 '21 at 21:11
Ok I was able to fix it now. Thank you for your help. – OuttaNowhere Jun 21 '21 at 21:56

Change variable in .then promise

0 Answers0