NullPointerException @ SavedStateHandle ViewModel w/ Hilt

Question

My app crashes when running my viewmodel below

@HiltViewModel
class ReportViewModel @Inject internal constructor(
    savedStateHandle: SavedStateHandle,
    private val monthRepository: MonthRepository
) : ViewModel() {

    //error in this line (monthId) says NullPointerException
    private val monthId: Long = savedStateHandle.get<Long>(MONTH_ID_SAVED_STATE_KEY)!! 

    val report = monthRepository.getMonthData(monthId).asLiveData() 

    companion object {
        private const val MONTH_ID_SAVED_STATE_KEY = "monthId"
    }
}

The error is java.lang.NullPointerException. I am using safeArgs. See my ViewHolder below.

inner class ViewHolderOne(var binding: ListMonthItemBinding) :
    RecyclerView.ViewHolder(binding.root) {
    init {
        binding.root.setOnClickListener {

            binding.month?.let { month ->
                navigateToMonth(month, it)
            }
        }
    }
    private fun navigateToMonth(
        month: Month,
        view: View
    ) {
        val direction =
            MonthFragmentDirections.actionNavMonthsToNavReports(
                month.identification
            )
        view.findNavController().navigate(direction)
    }

    fun bind(months: Month) {
        binding.apply {
            month = months
            executePendingBindings()
        }
    }
}

When I start to navigate to my detailFragment. The app starts to crash saying NullPointerException.

The code below is my nav_graph

<fragment
    android:id="@+id/nav_months"
    android:name="com.appname.ui.report.MonthFragment"
    android:label="@string/menu_months"
    tools:layout="@layout/fragment_month" >
    <action
        android:id="@+id/action_nav_months_to_nav_reports"
        app:destination="@id/nav_reports" />

</fragment>
<fragment
    android:id="@+id/nav_reports"
    android:name="com.appname.ui.report.ReportFragment"
    android:label="@string/report" >
    <argument
        android:name="monthId"
        app:argType="long" />
</fragment>

And here is the ReportFragment

@AndroidEntryPoint
class ReportFragment : Fragment() {

    private val reportViewModel: ReportViewModel by viewModels()

    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
        ): View {
            val binding = DataBindingUtil.inflate<FragmentReportBinding>(
            inflater,
            R.layout.fragment_report,
            container,
            false
        ).apply {
            viewmodel = reportViewModel
            lifecycleOwner = viewLifecycleOwner
        }
        return binding.root
    }
}

I referenced the code from Sunflower App of Google. But I think I miss something.

How to fix this crash?

Can you include your `` destination in your Navigation graph? — ianhanniballake, Jun 22 '21 at 02:32
hi @ianhanniballake already included. I edited my post. kindly check if something is wrong. — Rence Rei, Jun 22 '21 at 05:00
Thanks, that part looks fine. One additional question - how are you getting your ViewModel instance in your `ReportFragment`? — ianhanniballake, Jun 22 '21 at 05:17
thank you @ianhanniballake. already updated the post. kindly check again. — Rence Rei, Jun 22 '21 at 05:54

Rence Rei · Accepted Answer · 2021-06-23T04:08:25.280

Got the issue solved. The problem is I never noticed that my MONTH_ID_SAVED_STATE_KEY value at the ReportViewModel is different from my argument name at nav_graph

It should be

// ReportViewModel.kt
companion object {
    private const val MONTH_ID_SAVED_STATE_KEY = "monthId"
}

// nav_graph.xml
<argument
    android:name="monthId"
    app:argType="long" />

Already updated the code at my post for future reference.

NullPointerException @ SavedStateHandle ViewModel w/ Hilt

1 Answers1