0

I am trying to create a Discord Bot that reads users messages and detects when an Amazon link(s) is/are present in their message.

If I use a multi-line string I capture different results from when the message is used on a single line.

Here is the code I am using:

import re

AMAZON_REGEX = re.compile("(http[s]?://[a-zA-Z0-9.-]*(?:amazon|amzn).["
                          "a-zA-Z]+(?:.+?(?:ref=[^?]+)|.+(?= )|[^?]+))")

def extract_url(message):
    foo = AMAZON_REGEX.findall(message)
    return foo

user_message = """https://www.amazon.co.uk/dp/B07RLWTXKG blah blah 
hello 
https://www.amazon.co.uk/dp/B07RLWToop foobar"""

print(extract_url(user_message))

The result of the above code is: ['https://www.amazon.co.uk/dp/B07RLWTXKG blah blah', 'https://www.amazon.co.uk/dp/B07RLWToop']

However, if I change user_message from a multiline string to a single line one then I get the following result: ['https://www.amazon.co.uk/dp/B07RLWTXKG blah blah hello https://www.amazon.co.uk/dp/B07RLWToop']

Why is this the case? Also, how do I capture just the URL without the rest of the users' messages?

thoerni
  • 535
  • 5
  • 21
knowledge_seeker
  • 811
  • 1
  • 8
  • 18

2 Answers2

2

It seems like you're having an issue with the exact regex you're using.

Why does the newline change the output?

After parsing the link, it seems like your regex captures the following words, separated by spaces, but the newline character stops the regex from continuing. The fact that there's a newline between "blah" and "hello" in the first case is what's causing the "hello" to not be captured in the multi-line case. As you might know, there's a newline character (\n), a bit like a, * and other character exist.

Only capturing the link

I'm not quite sure what format the amazon link would come in, so it's difficult to say how it should look. However, you know that the link will not contain a space, so stopping the matching when you see a space character would be optimal.

(http[s]?:\/\/[a-zA-Z0-9.-]*(?:amazon|amzn).[a-zA-Z]+(?:.+?(?:ref=[^?]+)|.+(?= )|[^?]+))

(http[s]?:\/\/[a-zA-Z0-9.-]*(?:amazon|amzn).[a-zA-Z]+(?:.+?(?:ref=[^?]+)|[^ ]+(?= )|[^?]+))

In the example above, I turned one of your last . (basically "match all characters") into [^ ] (basically "match all except for a space"). This means you won't start matching the words following the spaces after the word.

Good luck with the Discord bot!

Gustav
  • 76
  • 7
0

So the reason you're getting a different result between your two different input sources is because you're not doing any checks for the presence of new lines in your regex. This answer goes into a little more detail about how your regex might need to be modified to detect a newline string.

But - if what you really want is just to get a list of links without the rest of the text, you're better off using a different regex string designed to capture just the URL. This post has several different regex strategies for matching just a single URL.

dogversioning
  • 91
  • 5