SwiftUI on appear AVAudioPlayer plays multiple times

Question

Im trying to add a AVAudioPlayer for background music on my app, I am initiating the player at the main screen, trying to start playing when the app opens but get unexpected behavior...
It plays and instantly keeps sort of creating new players and playing those players so there is tens of the same sound playing at the same time

Initiating and playing function for the music

if let path = Bundle.main.path(forResource: sound, ofType: type) {
    do {
        backgroundPlayer = try AVAudioPlayer(contentsOf: URL(fileURLWithPath: path))
        backgroundPlayer?.play()
    } catch {
        print("BACKGROUND MUSIC ERROR")
    }
}

On appear call for the function

.onAppear {
    audioController.backgroundMusic(sound: "bg", type: "wav")
}

Edit: Example code ...

import SwiftUI
import AVKit

struct ContentView: View {
    @ObservedObject var audioController = AudioController()

    var body: some View {
         Text("Hello, world!")
             .onAppear {
                 audioController.playBackgroundMusic(sound: "bg", type: "wav")
             }
    }
}

class AudioController: ObservableObject {
     var player: AVAudioPlayer?    

     func playBackgroundMusic(sound: String, type: String) {
        if let path = Bundle.main.path(forResource: sound, ofType: type) {
            do {
                player = try AVAudioPlayer(contentsOf: URL(fileURLWithPath: path))
                player?.play()
            } catch {
                print("BACKGROUND MUSIC ERROR")
            }
        }
    }
}

Try to include a [mre]. This is not enough code to debug the issue. — jnpdx, Jul 06 '21 at 00:43

workingdog support Ukraine · Answer 1 · 2021-07-06T01:21:28.767

2

you could try something like this:

func playBackgroundMusic(sound: String, type: String) {
    if !(player?.isPlaying ?? false) {
        if let path = Bundle.main.path(forResource: sound, ofType: type) {
            do {
                player = try AVAudioPlayer(contentsOf: URL(fileURLWithPath: path))
                player?.play()
            } catch {
                print("BACKGROUND MUSIC ERROR")
            }
        }
    }
}

edited Jul 06 '21 at 01:21

answered Jul 06 '21 at 00:59

workingdog support Ukraine

26,280
4
27
37

I was trying to do something like this, was struggling, thanks for sharing this approach – BlueStarXD Jul 06 '21 at 02:36

score 0 · Accepted Answer · answered Jul 06 '21 at 01:16

0

Found out it was actually just a "simulator" bug, when the app open from the xcode build it keeps playing the sound over and over ... but after closing and reopening the app, the sound plays as expected.

answered Jul 06 '21 at 01:16

BlueStarXD

73
6

SwiftUI on appear AVAudioPlayer plays multiple times

2 Answers2