How can I concatenate the foreach function with something else?

Question

I'm trying to fill the empty array called $Errors with some items to make some restrictions on my uploading form. So I'm trying to put a <div> tag as an item inside the array and that div tag holds some strings and I want to concatenate these strings with a foreach loop as shown in the code below but it keeps giving an error and I don't actually know how to concatenate a function like foreach with strings.

$Errors= array();
$Ext= array('jpg','png','jpeg','bmp','gif');
$FileName= $_FILES ['UploadedFile']['name'];
$FileExt=strtolower(end(explode(".",$FileName)));

if(!in_array($FileExt,$Ext)):
$Errors[]="<div>The file that you're uploading is " . $FileName . " And it is not an image file, only these file types are supported " . foreach($Ext as $AllowedExt):echo $AllowedExt;
endforeach;"</div>";endif;

Might want to use [implode](https://www.php.net/manual/en/function.implode.php) instead of `foreach` — brombeer, Jul 06 '21 at 15:48

DevWithZachary · Accepted Answer · 2021-07-06T15:53:39.833

0

Trying to loop over an array while your building a string is.. messy at best.

Build your string from the arrays content first and then concat that onto the rest of the string. You can also use implode to convert an array into a string.

$Errors= array();
$Ext= array('jpg','png','jpeg','bmp','gif');
$ExtAsString =  implode(",", $Ext);
$FileName= $_FILES ['UploadedFile']['name'];
$FileExt=strtolower(end(explode(".",$FileName)));

if(!in_array($FileExt,$Ext)):
    $Errors[]="<div>The file that you're uploading is " . $FileName . " And it is not an image file, only these file types are supported " . $ExtAsString . "</div>";
endif;

edited Jul 06 '21 at 15:53

answered Jul 06 '21 at 15:50

DevWithZachary

3,545
11
49
101

No need to build the string FIRST when using implode – brombeer Jul 06 '21 at 15:52
Well ok badly written let me edit, but the point is get the string built one way or another first – DevWithZachary Jul 06 '21 at 15:53
While not false, there's no need to build it first: `$test="
".implode(",", $Ext)."
";` would work fine. – brombeer Jul 06 '21 at 15:57
1

PHP doesn't like this advice: https://3v4l.org/i95Qj – mickmackusa Jul 06 '21 at 16:04
This code throws a `Notice: Only variables should be passed by reference` – B001ᛦ Jul 06 '21 at 16:43
@Zachary tyvm now it looks much easier and works just fine – Ahmus Jul 06 '21 at 18:18
@brombeer True, it also works just fine ty for the note. – Ahmus Jul 06 '21 at 18:24

score 0 · Answer 2 · answered Jul 06 '21 at 15:52

0

Write your foreach() statement as a separate function and concatenate it with your text. And besides the items in your allowed extension isn't that too many to written directly in the text.

answered Jul 06 '21 at 15:52

Nasiru Ibrahim

19
2

Welcome to SO! Consider adding code samples to explain your answer. – displacedtexan Jul 06 '21 at 20:21
I'm just practicing this isn't a live project so the text isn't really getting my attention atm..ty for the note though – Ahmus Jul 07 '21 at 15:42

How can I concatenate the foreach function with something else?

2 Answers2