6

I have the following (simplified XML):

<?xml version="1.0" encoding="UTF-8" ?>

<products>
  <product>
    <artnr>xxx1</artnr>
  </product>
</products>

And the following (again simplified PHP code):

$xml= @simplexml_load_file($filename);

foreach ($xml->product as $product) {
    if (!$this->validate_xml_product($product)) {
        continue;
    }
}

function validate_xml_product($product)
{
    if (!property_exists('artnr', $product)) {
        // why does it always validate to true?
    }
}

For some reason the product never validates.

Isn't property_exists the correct way of finding out whether there is an artnr element in $product?

skaffman
  • 398,947
  • 96
  • 818
  • 769
PeeHaa
  • 71,436
  • 58
  • 190
  • 262

3 Answers3

9

The order of parameter in your code is reversed. Correct is first the object then the property-name:

if (!property_exists($product, 'artnr')) {

And apparently this only works for "real" properties. If the property is implemented using the __get-Method this won't work either.

vstm
  • 12,407
  • 1
  • 51
  • 47
  • AAARRRGGGGHHH... Damn you PHP for screwing with peoples mind by just randomly switching function parameters! :) Thanks! – PeeHaa Jul 30 '11 at 15:35
3

I think the arguments are crossed. First param should be the class, second the property...

http://php.net/manual/de/function.property-exists.php

sthzg
  • 5,514
  • 2
  • 29
  • 50
1

Use:

function validate_xml_product($product)
{
    $children=$product->children();
    foreach($children as $child){
         if ($child->getName()=='artnr') {
             return true;
         }
    }
    return false;
}
Darm
  • 5,581
  • 2
  • 20
  • 18