dice roll check if the number is between 1 and 6

Question

I'm working on a little dice game but i'm having a problem checking if the number is between 1 and 6.

For an example 1,2,3,4,5,6 all work fine but if i put a zero in front of the number it will still roll the dice but i want it to be only a number from 1 to 6 and i can workout what i'm doing wrong and was hoping maybe someone could tell me.

let diceRolled = false;

const rollDice = (guess) => {
  console.log('guess:', guess);
  
  if (guess == '' || guess === undefined) {
    console.log(`You didn't pick a number from 1 to 6`);
  } else if (diceRolled) {
    console.log(`Dice has already been rolled. Please try again soon.`);
  } else if (!(guess > 0 && guess < 7)) {
    console.log(`You can only pick a number from 1 to 6`);
  } else {
    diceRolled = true;
    let dice = Math.floor(Math.random() * 6) + 1;
    console.log(`Dice has been rolled.`);
    setTimeout(() => {
      if (dice == guess) {
        console.log(`Correct guess - The dice landed on: ${dice} :thumbsup:`);
      } else {
        console.log(`Incorrect guess - The dice landed on: ${dice} :thumbsdown:`);
      }
      diceRolled = false;
    }, 5000);
  }
};

rollDice('03');

Duplicate of: https://stackoverflow.com/questions/4959975/generate-random-number-between-two-numbers-in-javascript — LaurensUP, Sep 03 '21 at 11:20
Please [edit] your post and provide a [mre]. Which input fails? — Sebastian Simon, Sep 03 '21 at 11:21
Because that's my problem if someone puts 03 it will still roll the dice but i don't want it to roll the dice . If the number has a zero in front i want to log `You can only pick a number from 1 to 6` — yellowleg, Sep 03 '21 at 11:22
@Sebastian Simon there are no input fields the guess is a message from my socket io chat — yellowleg, Sep 03 '21 at 11:25
@yellowleg Ah. `Array.from("123456").includes(guess)`, then. — Sebastian Simon, Sep 03 '21 at 11:26
Are you aware of the differences of `==` and `===` and how similar to `==`, `<` and `>` will coerce the values and `'03' > 1` as `03` is coerced into `3`? This is why your numeric check fails: any number of leading zeros is ignored. — crashmstr, Sep 03 '21 at 11:33
@Robby It isn’t. That’s the point. `"03"` is supposed to be rejected. — Sebastian Simon, Sep 03 '21 at 12:46

score -1 · Answer 1 · answered Sep 03 '21 at 11:30

The below should answer your question. Specifically, I've replaced the !(guess > 0 && guess < 7) condition with !Array.from('123456').includes(guess).

let diceRolled = false;

const rollDice = (guess) => {
  console.log('guess:', guess);
  
  if (guess == '' || guess === undefined) {
    console.log(`You didn't pick a number from 1 to 6`);
  } else if (diceRolled) {
    console.log(`Dice has already been rolled. Please try again soon.`);
  } else if (!Array.from('123456').includes(guess)) {
    console.log(`You can only pick a number from 1 to 6`);
  } else {
    diceRolled = true;
    let dice = Math.floor(Math.random() * 6) + 1;
    console.log(`Dice has been rolled.`);
    setTimeout(() => {
      if (dice == guess) {
        console.log(`Correct guess - The dice landed on: ${dice} :thumbsup:`);
      } else {
        console.log(`Incorrect guess - The dice landed on: ${dice} :thumbsdown:`);
      }
      diceRolled = false;
    }, 5000);
  }
};

rollDice('3');

However, I'm curious to why 01, 02, 03, 04, 05, 06 aren't accepted?

dice roll check if the number is between 1 and 6

1 Answers1