Problem with predefined arguments on hackerearth platform

Question

I have a problem states:

WRITE A PROGRAM TO FIND THE MINIMUM NUMBER IN A LIST OF GIVEN N INTEGERS.

 #include<bits/stdc++.h>
 using namespace std;
 int FindIt (vector<int> arr)
 {
    **//WRITE YOUR CODE HERE`enter code here`**

 }
 int main()
 {
     ios::sync_with_stdio(0);
     cin.tie(0);
     int n;
     cin>>n;
     vector<int> arr(n);
     for(int i_arr=0;i_arr < n;i_arr++)
     {
         cin>>arr[i_arr];
     }
     int out_;
     out_ =FindIt(arr);
     cout<<out_;
 }

I tried running the program with the below approach but every time it shows 0 as output.

I don't know any other approach as i am a beginner.

 #include<bits/stdc++.h>
 using namespace std;
 int FindIt (vector<int> arr)
 {
     int min=0;
     int n=arr.size();
     int i;
     for(i=0;i<n;i++)
     {
         if(arr[i+1]<arr[i])
         min=arr[i+1];
     }
     return min;

 }
 int main()
 {
     ios::sync_with_stdio(0);
     cin.tie(0);
     int n;
     cin>>n;
     vector<int> arr(n);
     for(int i_arr=0;i_arr < n;i_arr++)
     {
         cin>>arr[i_arr];
     }
     int out_;
     out_ =FindIt(arr);
     cout<<out_;
 }

Think a bit harder about your indexing. What happens when `i == n-1`? — molbdnilo, Nov 29 '21 at 07:49
Hi! Use a debugger or some cout statements to get a better understanding what your program is actually doing. Then the solution will become obvious! Have fun! — U. W., Nov 29 '21 at 08:03

score 1 · Answer 1 · answered Nov 29 '21 at 08:31

The innocuously looking statement

 int min=0;

had introduced 0 as a value in your input. If all values in your input are increasing compared to preceding ones, the 0 is can be a "minimum" as the condition was never met. You have to compare vector element with current minimum, something like:

int min = arr[0];
for ( auto i = 1, n = arr.size(); i < n; i++)
   if(arr[i] < min)  
      min = arr[i];

Problem with predefined arguments on hackerearth platform

1 Answers1