PHP sql insert won't work from a html form

Question

For some reason this little php insert won't work, could someone help? I've been trying to upload some data from a form in html. Here's some code

$dbServerName = "localhost";
$dbUsername = "root";
$dbPassword = "";
$dbName = "kollegium_data";

$connection = mysqli_connect($dbServerName, $dbUsername, $dbPassword, $dbName);

if(isset($_POST['submit'])){ 
    $name = $_POST['teacher'];
    $email = $_POST['postdate'];
    $contact = $_POST['posttext'];
    if($name !=''||$email !='') {

        mysql_query("INSERT INTO posts(teacher, postdate, posttext) VALUES ('$name', '$email', '$contact')");
        echo "sikeres";
    }
    else{
        echo "sikertelen";
    }
}
$connection->close();

<form action="insert.php" method="POST">
    Neve: <input type="text" name="teacher" id="tanar" /><br/>
    Jelenlegi dátum (év,hónap,nap): <input type="text" name="postdate" id="datum"/><br/>
    Kiírandó szöveg (max. 3500 karakter): <input type="text" name="posttext" id="kiiras"/><br/>
    <input type="submit">
</form>

mysql_* functions are deprecated as of PHP 5.5.0, and removed as of PHP 7.0.0. Switch your code to use [PDO](https://secure.php.net/manual/en/pdo.prepared-statements.php) or [mysqli](http://php.net/manual/en/mysqli.quickstart.prepared-statements.php) instead. Be sure to use prepared statements and parameter binding, so **you'll never have to worry about quoting issues again.** Also, you cannot mix MySQL APIs, so `mysql_query` will not work with `mysqli_connect` — aynber, Dec 02 '21 at 15:33
Just an FYI whomever marked this close / duplicated. He never asked the mysql question problem, just a user here noticed it. He asked why it doesn't insert, and that's because of a HTML issue. So it's not really a duplicate of a MYSQL issue. — Forbs, Dec 02 '21 at 16:01

score 4 · Answer 1 · answered Dec 02 '21 at 15:19

4

You didn't create a $_POST['submit'] variable.

Change

<input type="submit">

To

<input type="submit" name='submit'>

answered Dec 02 '21 at 15:19

Forbs

1,256
1
7
9

Slava Rozhnev · Answer 2 · 2021-12-02T15:27:26.257

Since you use mysqli_connect you must to use mysqli_query where first parameter is $connection:

mysqli_query(
    $connection, 
    "INSERT INTO posts(teacher, postdate, posttext) VALUES ('$name', '$email', '$contact')"
);

Also your code open to SQL Injection attack, so you need to use prepared statement:

$stmt = mysqli_prepare(
    $connection,
    "INSERT INTO posts(teacher, postdate, posttext) VALUES (?, ?, ?)"
);

mysqli_stmt_bind_param($stmt, "sss", $name, $email, $contact);

mysqli_stmt_execute($stmt);

PHP sql insert won't work from a html form

2 Answers2