warning on buttonPressed method

Question

I have declare a method in my .h file as

-(IBAction)buttonTapped:(id) sender;

and I apply this method in my .m file as

-(IBAction)buttonTapped:(id)sender
{
    NSString* themessage=[NSString stringWithFormat:@"I'm %@ and feeling %@ about it",[activities objectAtIndex:[tweetPicker selectedRowInComponent:0]],
                          [feelings objectAtIndex:[tweetPicker selectedRowInComponent:1]]];
    NSLog (themessage);

}

but at the line NSLog (themessage);

it shows me warning likd "format string is not string literal(potentially unsecure"

pls suggest me what i should do...

possible duplicate of [Issue With Code: Format string is not a string literal](http://stackoverflow.com/questions/5428325/issue-with-code-format-string-is-not-a-string-literal) — highlycaffeinated, Aug 11 '11 at 12:35

score 3 · Answer 1 · answered Aug 11 '11 at 12:31

3

You didn't specify a format string:

NSLog(@"%@", themessage);

Some useful examples of how to use the function on CocoaDev.

answered Aug 11 '11 at 12:31

Perception

79,279
19
185
195

score 1 · Answer 2 · answered Aug 11 '11 at 12:31

1

Try this:

  NSLog(@"Output : %@",themessage);

answered Aug 11 '11 at 12:31

Devang

11,258
13
62
100

score 1 · Answer 3 · answered Aug 11 '11 at 13:00

The first parameter to NSLog should be a format string, like @"I'm %@ and feeling %@", followed by the values for %@, %d, %f, etc:

-(IBAction)buttonTapped:(id)sender
{
    NSLog( @"I'm %@ and feeling %@ about it",
           [activities objectAtIndex:[tweetPicker selectedRowInComponent:0]],
           [feelings objectAtIndex:[tweetPicker selectedRowInComponent:1]] );
}

score 1 · Answer 4 · answered Aug 12 '11 at 11:10

Try This ..

-(IBAction)buttonTapped:(id)sender { NSString* themessage=[NSString stringWithFormat:@"I'm %@ and feeling %@ about it",[activities objectAtIndex:[tweetPicker selectedRowInComponent:0]], [feelings objectAtIndex:[tweetPicker selectedRowInComponent:1]]];

**NSLog (@"Output = %@ ",themessage);**

}

score 1 · Accepted Answer · edited Mar 13 '15 at 03:51

1

You should have to give the reference of the data type. You are going to display message and that is type of string so you should have to write like below code:

NSLog(@"Output : %@",themessage);

edited Mar 13 '15 at 03:51

user229044

232,980
40
330
338

answered Aug 12 '11 at 12:39

Shreyash Mahajan

23,386
35
116
188

score 0 · Answer 6 · edited Aug 03 '12 at 13:08

0

Try that after allocating a string object via alloc.

edited Aug 03 '12 at 13:08

Peter DeWeese

18,141
8
79
101

answered Aug 11 '11 at 12:51

Arpit B Parekh

1,932
5
36
57

warning on buttonPressed method

6 Answers6