Should find if the string of numbers is a valid pin

Asked Dec 15 '21 at 07:39

Active Dec 15 '21 at 07:39

Viewed 17 times

For some reason this code prints true for numbers without a length of 4 or 6 and I'm not sure why.

def validate_pin(pin):
    try:
        pin = int(pin)
    except ValueError:
        print(False)
        exit()
    if len(str(pin)) == 4 or 6:
        if pin < 0:
            print(False)
            exit()
        elif pin >= 0:
            print(True)
            exit()
    elif len(pin) != 4 or 6:
        print(False)
        exit()

asked Dec 15 '21 at 07:39

hello donkey

Your conditional statement has issues. – Vishnudev Krishnadas Dec 15 '21 at 07:40
`or 6` is always true – Sayse Dec 15 '21 at 07:40
1

Additionally the order of the checks is wrong. If you enter the PIN "0123" it should be valid. But you transform it to an integer and then back to a string and that gives you "123". Suddenly the valid PIN isn't valid anymore. – Matthias Dec 15 '21 at 07:43

Should find if the string of numbers is a valid pin

0 Answers0