Gurobi. Very interesting! And you have chosen C++ to interface it. Good.
I try to give you a very simple answer, with very simple statements.
All the code has lowest complexity and will work with really only a few statements.
There is no need for many C-like statements, because C++ is a very expressive language. You can do really an understandable or "easily readable" abstraction for your problem. If you look in main, an do see only a few lines of code, and then you will understand what I mean.
Additionally, I will give you a detailed explanation for everything. So, I will not just dump code, but explain line by line. Additionally I add many comments and use reasonable long and "speaking" variable names.
This code will be in C++, and not C-Style, as you can often see.
Then let us a little bit concentrate on how we would do things in C++.
If we look at your first definition:
const int A = 4;
double B[] = { 1, 2, 3 };
double C[][A] = {
{ 5, 1, 0, 3 },
{ 7, 0, 2, 4 },
{ 4, 6, 8, 9 }
};
We can see here C-Style arrays. Those with the [] brackets. The number of elements of the B array is defined by the number of initializer elements. So, 3 elements in the initializer list will give use 3 elemnts in the array --> The array size is 3. OK, Understood
The C-elements are a 2-dimensional Matrix. The number of columns is defined by `const int A = 4’. So, I am not sure, if A is just a size or really a coefficient. But in the end, it does not matter. The number of rows is given by the number of lines in the source text file. Sor, we have a matrix with 3 rows and 4 columns.
First important information: In C++ we are not using C-Style arrays []. We have basically 2 versatile working-horses for that:
- The
std::array, if the size of the array is known at compile time
- The C++ main container, the
std::vector. An array that can dynamically grow as needed. That is extremely powerful and used a lot in C++. It knows also, how many elements it contains, so now explicit definition like A=4 needed.
And the std::vector is the container to use for this purpose. Please read here about the std::vector. So, even if we do not know the number aof rows and columns in advance, we can use a std::vectorand itwill grow as needed.
For that reason, I am not sure, if The "const with value 4", is needed in your Coefficients-Information at all. Anyway, I will add it.
Next, C++ is an object-oriented language. In the very beginning of the language it was even called ‘C with objects’. The objects in C++ are modeled with classes or structs.
And one major idea of an object-oriented approach is, to put data, and methods, operating on this data, in one class (or struct) together.
So, we can define a Coefficient class and store here all coefficient data like your A, B, C. And then, and most important, we will add functions to this class that will operate on this data. In our special case we will add read and write functionality.
As you know, C++ uses a very versatile IO-stream library. And has so called “extraction” operators >> and “inserter” operators <<. The “streams” are implemented as hierarchical classes. That means, it does not matter on which stream (e.g. std::cout, a filestream or a stringstream) you use the << or >> operators, it will work basically everywhere in the same way.
And the extractor >> and inserter <<operators are already overloaded for many many existing and build-in data types. And because of that, you can output many different data types to for example std::cout.
But, this will of course not work for custom types, like our class “Coefficient”. But here, we can simply add the functionality, by defining the appropriate inserter and extractor operators. And after that, we can use our new type in the same way as other, built in data types.
Then let us look now on the first code example:
struct Coefficient {
// The data
int A{};
std::vector<double> B{};
std::vector<std::vector<double>> C{};
friend std::istream& operator >>(std::istream& is, Coefficient& coefficient);
friend std::ostream& operator << (std::ostream& os, const Coefficient& coefficient);
};
That is all. Simple, isn't it? Now the class has the needed functionality.
We will show later the implementation for the operators.
Note, this mechanism is also called (de)serialization, because the data of cour class will be written/read in a serial and human readable way. We need to take care the output and the input structure of the data is the same, so that we always can take our 2 operators.
You should understand already now, that we later can have an extremely simple and low complexity handling of IO operations in main or other functions. Let us look at main already now:
// Some example data in a stream
std::istringstream exampleFile{ R"(4
1 2 3
5 1 0 3
7 0 2 4
4 6 8 9 )" };
// Test/Driver code
int main() {
// Here we have our coefficients
Coefficient coefficient{};
// Simply extract all data from the file and store it in our coefficients variable
// This is just a one-liner, intuitive and simple to understand.
exampleFile >> coefficient;
// One-liner debug output. Even mor simple
std::cout << coefficient;
}
This looks very intuitive and similar to the input and output of other, build-in data types.
Let us now come to the actual input and output functions. And, because we want to keep it simple, we will structure your data in your “.dat” file in an easy to read way.
And that is: White space separated data. So: 81 999 42 and so on. Why is that simple? Because in C++ the formatted input functions (those with the extractor >>) will read such data easily. Example:
int x,y,z;
std::cin >> x >> y >> z
If you give a white space separated input as shown above, it will read the characters, convert it to numbers and store it in the variables.
There is one problem in C++. And that is, the end of line character ‘\n’ will in most cases also be treated as a white space. So, reading values in a loop, would not stop at the end of a line.
The standard solution for this problem is to use a non-formatted input function like std::getline and first read a complete line into a std::stringvariable. Then, we will put this string into a std::istringstream which is again a stream and extract the values from there.
In your “.dat” file you have many lines with data. So, we need to do the above operation repeatedly. And for things that need to be done repeatedly, we use functions in C++. We need to have a function, that receives a stream (any stream) reads the values, store them in a std::vector and returns the vector.
Before I show you this function, I will save some typing work and abbreviate the vector and the 2d-vector with a using statement.
Please see:
// Some abbreviations for easier typing and reading
using DVec = std::vector<double>;
using DDVec = std::vector<DVec>;
// ---------------------------------------------------------------------------
// A function to retrieve a number of double values from a stream for one line
DVec getDVec(std::istream& is) {
// Read one complete line
std::string line{}; std::getline(is, line);
// Put it in an istringstream for better extracting
std::istringstream iss(line);
// And use the istream_iterator to iterate over all doubles and put the data in the resulting vector
return { std::istream_iterator<double>(iss), {} };
}
You see, a simple 3-line function. The last line is maybe difficult to understand for beginners. I will explain it later. So, our function expects a reference to a stream as input parameter and then returns a std::vector<double> containing all doubles from a line.
So, first, we read a complete line into a variable of type std::string. Ultra simple, with the existing std::getlinefunction.
Then, we put the string into a std::istringstream variable. This will basically convert the string to a stream and allow us, to use all stream functions on that. An remember, why we did that: Because we want to read a complete line and then extract the data from there. Now the last line:
return { std::istream_iterator<double>(iss), {} };
Uh, what’s that? We expect to return a std::vector<double>. The compiler knows that we want to return such a type. And therefore he will kindly create a temporary variable of that type for us and use its range constructor no 5 () (see here) to initialize our vector. And with what?
You can read in the CPP reference that it expects 2 iterators. A begin-iterator and an end-iterator. Everything between the iterators will be inclusively copied to the vector.
And the std::istream_iterator (Please read here) will simply call the extractor operator >> repeatedly and with that reads all doubles, until all values are read.
Cool!
Next we can use this functionality in our class’ extractor operator >>. This will then look like this;
// Simple extraction operator
friend std::istream& operator >>(std::istream& is, Coefficient& coefficient) {
// Get A and all the B coefficients
coefficient.B = std::move(getDVec(is >> coefficient.A >> std::ws));
// And in a simple for loop, readall C-coeeficients
for (DVec dVec{ getDVec(is) }; is and not dVec.empty(); dVec = getDVec(is))
coefficient.C.push_back(std::move(dVec));
return is;
}
It will first read
- the value for A (
>> coefficient.A)
- then all white spaces that may exist in the stream, and then (
>> std::ws)
- the line with the B-coefficients (
getDVec(is)
LAst but not least, we use s imple for loop, to read all lines of the C-coefficients and add them to the 2d output vector. We will skip empty lines.
std::move will avoid copying of large data and give us a little better efficiency.
Output is even more simple. Using "loops" to show the data. Not much to explain here.
Now, we have all functions. We made our live simpler, by splitting up a big problem inti smaller problems.
The final complete code would then look like this:
#include <iostream>
#include <sstream>
#include <vector>
#include <algorithm>
#include <iterator>
// Some abbreviations for easier typing and reading
using DVec = std::vector<double>;
using DDVec = std::vector<DVec>;
// ---------------------------------------------------------------------------
// A function to retrieve a number of double values from a stream for one line
DVec getDVec(std::istream& is) {
// Read one complete line
std::string line{}; std::getline(is, line);
// Put it in an istringstream for better extracting
std::istringstream iss(line);
// And use the sitream_iterator to iterate over all doubles and put the data in the resulting vector
return { std::istream_iterator<double>(iss), {} };
}
// -------------------------------------------------------------
// Cooeficient class. Holds data and methods to operate on this data
struct Coefficient {
// The data
int A{};
DVec B{};
DDVec C{};
// Simple extraction operator
friend std::istream& operator >>(std::istream& is, Coefficient& coefficient) {
// Get A and all the B coefficients
coefficient.B = std::move(getDVec(is >> coefficient.A >> std::ws));
// And in a simple for loop, readall C-coeeficients
for (DVec dVec{ getDVec(is) }; is and not dVec.empty(); dVec = getDVec(is))
coefficient.C.push_back(std::move(dVec));
return is;
}
// Even more simple inserter operator. Output values in loops
friend std::ostream& operator << (std::ostream& os, const Coefficient& coefficient) {
os << coefficient.A << '\n';
for (const double d : coefficient.B) os << d << ' '; os << '\n';
for (const DVec& dv : coefficient.C) {
for (const double d : dv) os << d << ' '; os << '\n'; }
return os;
}
};
// Some example data in a stream
std::istringstream exampleFile{ R"(4
1 2 3
5 1 0 3
7 0 2 4
4 6 8 9 )" };
// Test/Driver code
int main() {
// Here we have our coefficients
Coefficient coefficient{};
// Simply extract all data from the file and store it in our coefficients variable
exampleFile >> coefficient;
// One-liner debug output
std::cout << coefficient;
}
Please again see the simple statements in main.
I hope I could help you a little.
Some additional notes.
- In professional software development, code without comments is considered to have 0 quality.
- Also, the guidelines on SO recommend, to not just dump code, but also give a comprehensive explanation.
- Please do not use:
while ( isf.good() ) { It is considered as very bad practice and error prone. Please read this
- If you made the decision to go to C++, you should try to go away from typycal serial C programming and use a more object oriented approach.
If you should have further questions then ask, I am happy to answer. Thank you for your question.
