How to launch a script for a list of ip addresses (bash script)

Question

i have a problem with my bash shell script. This is my code:

#!/bin/bash/

while read line  
do   
   echo -e "$line
"  
sleep 5;
done < Ip.txt

sshpass -p 'Password' ssh -o StrictHostKeyChecking=no root@$ip -t "cd /exemple/ && sh restart-launcher.sh;exec \$SHELL -l"

My script allows to launch for each ip (Ip.txt) in the folder "exemple" a script(restart-launcher.sh) but when I launch it , it only lists the ip without taking this part into account:

sshpass -p 'Password' ssh -o StrictHostKeyChecking=no root@$ip -t "cd /folders/ && sh restart-launcher.sh;exec \$SHELL -l"

How do I create a bash script that works in Linux?

The `sshpass` line isn't inside the loop, so it's only done once when the loop is done. — Barmar, Feb 01 '22 at 08:37
"The sshpass line isn't inside the loop, so it's only done once when the loop is done." how to do that ? (Srry i just started the bash ) — IppoMuto, Feb 01 '22 at 08:55
The variable `ip` is never assigned to. Therefore it is empty. I suggest to put a `set -u` at the start of your script, to catch this kind of error. — user1934428, Feb 01 '22 at 13:18

score 1 · Accepted Answer · answered Feb 01 '22 at 08:53

1

#!/bin/bash/
while read -r line; do   
    echo -e "$line\n"
    sshpass -p 'Password' ssh -o StrictHostKeyChecking=no root@$line -t \
        "cd /exemple/ && sh restart-launcher.sh;exec \$SHELL -l"
    sleep 5
done < Ip.txt

Now, we could have a discussion about using sshpass (or rather, why you shouldn't), but it feels out of scope.

So, all commands you wish to be looped over need to be inside the loop. As you read sets the variable $line, that is what you need to use. In your example, you used the variable $ip which you haven't set anywhere.

answered Feb 01 '22 at 08:53

Kaffe Myers

424
3
9

See also https://stackoverflow.com/questions/13800225/while-loop-stops-reading-after-the-first-line-in-bash – Barmar Feb 01 '22 at 08:57
If my answer led to you sorting things out, please set it as the accepted answer @IppoMuto – Kaffe Myers Feb 01 '22 at 09:38
hi, @Kaffe Myers , when i run my script, i have this "Name or service not knownname 1.1.1.1", do you know what the problem is? – IppoMuto Feb 07 '22 at 15:33
Well, seems you have `1.1.1.1` in your `Ip.txt` file, which I expect to be incorrect, unless you work for cloudflare: https://www.cloudflare.com/learning/dns/what-is-1.1.1.1/ If that is not it, then I need more information to have a clue. – Kaffe Myers Feb 07 '22 at 17:37
this ip 1.1.1.1 it's an example :) – IppoMuto Feb 08 '22 at 16:17
Do your ip-file only contain one ip per line? – Kaffe Myers Feb 09 '22 at 14:58
Yes only One ip per line – IppoMuto Feb 10 '22 at 09:08
Are you able to ssh into the IP that brings error with the same command manually? – Kaffe Myers Feb 10 '22 at 09:10
Yes i can via ssh – IppoMuto Feb 10 '22 at 12:38
Well, I can sit and throw questions all day, but you might have a better and faster resolution analysing the debug information in the script. Run it with `bash -x` and see if you can spot the issue. – Kaffe Myers Feb 10 '22 at 13:23
ok no problem, thanks again for your help :) – IppoMuto Feb 10 '22 at 15:16

score 0 · Answer 2 · answered Feb 01 '22 at 08:55

If we assume that "Ip.txt" contains a list of only IPs perhaps what you mean to do is use sshpass inside the while-loop so it runs for each IP in the .txt file.

#!/bin/bash/

while read line  
do   
   echo -e "$line
"  
sshpass -p 'Password' ssh -o StrictHostKeyChecking=no root@$line -t "cd /exemple/ && sh restart-launcher.sh;exec \$SHELL -l"
sleep 5;
done < Ip.txt

sshpass has been moved into the while loop and $ip replaced with $line

How to launch a script for a list of ip addresses (bash script)

2 Answers2