optimizing the code, calling different class on deserialization

Question

I need help, how can I shorten this code. I have a response message which I need to deserialize based on code type. the deserialization is of different classes. Below code works if I write for each loop inside each "if"statement but I am looking for a better way to write this

private async Task GetMappedCode( string id, List<string> mappedCode, string dresponseMessage, string codeType)
        {            
            if (codeType == "discipline")
            {
               var myDeserializedClass = new List<DisciplineCode>();
               myDeserializedClass = JsonConvert.DeserializeObject<List<DisciplineCode>>(dresponseMessage);
            }
            else if(codeType == "system")
            {
                var myDeserializedClass = new List<SystemCode>();
                myDeserializedClass = JsonConvert.DeserializeObject<List<SystemCode>>(dresponseMessage);
            }
            
            foreach (var did in myDeserializedClass)
            {
                if (did.id == $"rdl:{id}")

create a dictoniary containing your string and its corresponding type and itterate over it — Denis Schaf, Feb 03 '22 at 09:06
Something like this maybe? https://stackoverflow.com/a/42505360/2946329 — Salah Akbari, Feb 03 '22 at 09:09
you can split method to two differents methods and call them. This will be less complex. — nzrytmn, Feb 03 '22 at 10:01

Sajed · Accepted Answer · 2022-02-03T09:54:45.350

1

You have to refactor your code to another function and use string to type dictionary

Dictionary<string, Type> CodeTypes = new Dictionary<string, Type>()
{
    { "discipline", typeof(DisciplineCode)},
    { "system", typeof(SystemCode)}
};

private async Task GetMappedCode( string id, List<string> mappedCode, string dresponseMessage, string codeType)
{
    var myDeserializedClass = typeof(YourClass)
       .GetMethod("GetDeserializedList")
       .MakeGenericMethod(CodeTypes[codeType])
       .Invoke(this, dresponseMessage);

    etc ...
}

private IList<T> GetDeserializedList<T>(string serializedJson) => JsonConvert.DeserializeObject<List<T>>(serializedJson);

edited Feb 03 '22 at 09:54

answered Feb 03 '22 at 09:19

Sajed

1,797
2
7
21

1

get error as operator < cannot be applied to operands of type method groups or Type on line var myDeserializedClass = GetDeserializedList(dresponseMessage); – ZZZSharePoint Feb 03 '22 at 09:31
@ZZZSharePoint , You are right, I didn't have tested it in IDE , I think this will work for you. – Sajed Feb 03 '22 at 09:59

optimizing the code, calling different class on deserialization

1 Answers1