Problems with function on Shell Script

Question

Trying to test functions on ShellScript, but I keep receiving the answer: "Command not found"

# Trying to create functions that receives arguments e have returns
# The function will receive two values and say hwo is bigger

bigger () {
if [$1 -gt $2]
then
   return $1
else
   return $2
fi
}

echo "Size does matter!!!!"
echo " "
printf "Enter the first number: - "
read data1
echo " "
printf "Enter the second number: - "
read data2
echo " "
printf "The bigger number is: - "
bigger $data1 $data2

The result I get is:

enter image description here

Pasting your code into [ShellCheck](https://www.shellcheck.net/) would have shown you your problem. — JRFerguson, Feb 08 '22 at 15:42

Tolis Gerodimos · Accepted Answer · 2022-02-08T15:46:44.563

0

You have a syntax error and bash tries to interpret [1 as a command. Add spaces to fix this

Change

if [$1 -gt $2]

to

if [ "$1" -gt "$2" ]

edited Feb 08 '22 at 15:46

answered Feb 08 '22 at 15:38

Tolis Gerodimos

3,782
2
7
14

Still no good. Looks like it doesn't seen that the word bigger is a function. – Leonardo Holanda e Silva Feb 09 '22 at 18:00
If your aim is to output to the screen the bigger number then you need to use echo instead of return. return $1 => echo $1 – Tolis Gerodimos Feb 09 '22 at 21:02
Now it works. Thanks a lot! – Leonardo Holanda e Silva Feb 10 '22 at 01:44
If it works, then you should approve the answer – Tolis Gerodimos Feb 10 '22 at 06:15

Problems with function on Shell Script

1 Answers1