Cannot resolve action in CreatedAtAction(nameof(ActionName))

Question

I have Api Controller and when create new object in database in Post method i want go to the other api action. But in case when method is specify called (GetByIdAsync) i got error Cannot resolve action GetByIdAsync. If action is called other name - everythink is ok.

Error code (additional screenshot First screenshot)

[ApiController]
[Route("items")]
public class ItemsController : ControllerBase
{
  private readonly ItemsRepository itemsRepository = new();

  [HttpGet("{id}")]
  public async Task<ActionResult<ItemDtos>> GetByIdAsync(Guid id)
  {
    var item = (await itemsRepository.GetAsync(id)).AsDto();

    if (item == null)
    {
      return NotFound();
    }

    return item;
  }

  [HttpPost]
  public async Task<ActionResult> CreateAsync(CreateItemDtos createItemDto)
  {
    var item = new Item {
    Name = createItemDto.Name, 
    Description = createItemDto.Description, 
    Price = createItemDto.Price,
    CreatedDate = DateTimeOffset.UtcNow
    };

    await itemsRepository.CreateAsync(item);

    //Cannot resolve action 'GetByIdAsync'
    return CreatedAtAction(nameof(GetByIdAsync), new {id = item.Id}, item);
  }
}

Working Code (additional screenshot Second screenshot)

[ApiController]
[Route("items")]
public class ItemsController : ControllerBase
{
  private readonly ItemsRepository itemsRepository = new();

  [HttpGet("{id}")]
  public async Task<ActionResult<ItemDtos>> GetByIdAsync2(Guid id)
  {
    var item = (await itemsRepository.GetAsync(id)).AsDto();

    if (item == null)
    {
      return NotFound();
    }

    return item;
  }

  [HttpPost]
  public async Task<ActionResult> CreateAsync(CreateItemDtos createItemDto)
  {
    var item = new Item {
    Name = createItemDto.Name, 
    Description = createItemDto.Description, 
    Price = createItemDto.Price,
    CreatedDate = DateTimeOffset.UtcNow
    };

    await itemsRepository.CreateAsync(item);

    return CreatedAtAction(nameof(GetByIdAsync2), new {id = item.Id}, item);
  }
}

Does this answer your question? [When methods have the name ...Async the exception "System.InvalidOperationException: No route matches the supplied values" occurs](https://stackoverflow.com/questions/62202488/when-methods-have-the-name-async-the-exception-system-invalidoperationexcept) — madreflection, Feb 14 '22 at 20:59

nelsontruran · Accepted Answer · 2022-08-01T02:03:09.427

4

I'm not 100% sure why it gives this error but a solution is to assign it to a local variable and use that.

  [HttpPost]
  public async Task<ActionResult> CreateAsync(CreateItemDtos createItemDto)
  {
    var item = new Item
    {
        Name = createItemDto.Name, 
        Description = createItemDto.Description, 
        Price = createItemDto.Price,
        CreatedDate = DateTimeOffset.UtcNow
    };

    await itemsRepository.CreateAsync(item);

    var actionName = nameof(GetByIdAsync2);
    return CreatedAtAction(actionName, new { id = item.Id }, item);
  }

edited Aug 01 '22 at 02:03

answered Jun 30 '22 at 22:48

nelsontruran

514
4
18

The really weird thing is if you change it to `const var actionName = nameof(GetByIdAsync2);` (i.e. make it a constant string) then R# gives the original error. – Matthew Watson Oct 26 '22 at 10:41
Have you tried adding options.SuppressAsyncSuffixInActionNames = false; See: https://stackoverflow.com/a/63834605/4787999 – Sego Jan 18 '23 at 22:31
Or use CreateAtRoute? – Sego Jan 18 '23 at 22:31
And name your method [HttpGet("{id:int}", Name = "CreateAsync")] – Sego Jan 18 '23 at 22:55

Cannot resolve action in CreatedAtAction(nameof(ActionName))

1 Answers1