Why is this returning some objects as promises?

Question

I am making a messaging system on a website that I'm making. I'm trying to get the sender's name from a database. I have async/await and the result from my function where I get an object with each message ID and the sender's name is returning a promise. Here is my function:

async function getMessageSenders(){
    let senders = {}
    inbox.forEach(async (message) => {
      if (message.sender === 'Baseball Stats') {
        senders[message.id] = message.sender
      } else {
        senders[message.id] = await database.users.where('uid', '==', message.sender)
        .get()
        .then((q) => {
          return q.docs.map((doc) => {
            const data = doc.data()
            return data.displayName
          })
        })
      }
    })
    return senders
  }

Georgy · Answer 1 · 2022-03-04T15:54:37.547

0

Because this expression senders[message.id] = await database.users.where('uid', '==', message.sender) assigns a promise actually, not a value. If you want to assign a value, you should put it in the .then() callback, like:

async function getMessageSenders(){
    let senders = {}
    inbox.forEach(async (message) => {
      if (message.sender === 'Baseball Stats') {
        senders[message.id] = message.sender
      } else {
        await database.users.where('uid', '==', message.sender)
        .get()
        .then((q) => {
          const promises = q.docs.map((doc) => {
            return doc.data()
          })
          Promises.all(promises).then(data => {
             senders[message.id] = data.map(item => item.displayName)
          })
        })
      }
    })
    return senders
  }

edited Mar 04 '22 at 15:54

answered Mar 04 '22 at 14:33

Georgy

1,879
2
9
14

Still giving me the same result unfortunately – izzzzthewiz Mar 04 '22 at 15:09
let's figure it out then: what is `doc.data()` you calling? maybe this returns promise as well? – Georgy Mar 04 '22 at 15:44
Yes, I just checked and `doc.data()` returns a promise – izzzzthewiz Mar 04 '22 at 15:47
edited my answer, try smth like this, so you should resolve all promises and assign to your senders then – Georgy Mar 04 '22 at 15:55
Still returning any item that isn't "Baseball Stats" as a promise. Could it have something to do with `return senders` at the end of the function? – izzzzthewiz Mar 04 '22 at 16:01
hm, where do you check this? try to console log in the callback `Promises.all(promises).then`. Also please note that `getMessageSenders()` returns promise as well. – Georgy Mar 04 '22 at 16:07

Why is this returning some objects as promises?

1 Answers1