Error while trying to shuffle a deck of cards

Question

I am trying to shuffle a deck of cards and I keep getting this error which I don't know how to solve. I am new to python and OOP so I think this should just be something that I overlooked.

This is my code:

class Deck:
    def __init__(self):
        self.deck = []

        for suit in suits:
            for rank in ranks:
                card_created = Card(suit, rank)
                self.deck.append(card_created)

    def __str__(self):
        deck_comp = ""
        for card in self.deck:
            deck_comp += "\n"+ card.__str__()
        return "The deck has: " + deck_comp

    def shuffle(self):
        random.shuffle(self.deck)

    def deal_one(self):
        return self.deck.pop()

new_deck = Deck()

print(new_deck.shuffle())

When I run the program I only get "None". However, before shuffling the deck, I get all the existing cards in order.

Does anyone know how to fix this?

`shuffle()` does not `return` a value. `new_deck.shuffle()` then `print(new_deck)` — 001, Mar 14 '22 at 23:46
Does this answer your question? [return, return None, and no return at all?](https://stackoverflow.com/questions/15300550/return-return-none-and-no-return-at-all) — G. Anderson, Mar 14 '22 at 23:47
@G.Anderson That question is about different ways of returning `None`. It doesn't directly address OP's question. — BrokenBenchmark, Mar 14 '22 at 23:49

score 0 · Accepted Answer · answered Mar 14 '22 at 23:48

0

Your shuffle() function doesn't return any value (and neither does random.shuffle(), which shuffles the list in-place).

Instead, you should perform the call to .shuffle() and print() on separate lines:

new_deck.shuffle()
print(new_deck.deck)

answered Mar 14 '22 at 23:48

BrokenBenchmark

18,126
7
21
33

This solved the issue, thank you so much – António Rebelo Mar 14 '22 at 23:59

Error while trying to shuffle a deck of cards

1 Answers1