C# naming convention for private members

Question

Possible Duplicate:
Naming convention for private fields

I read on msdn about C# naming conventions but they don't talk about naming private fields vs parameters.

public void SetAnimation(int framesX, int framesY)
{
    framesX = framesX; // the first one is private class member
    framesY = framesY;
}

I must name private field differently than a parameter. I can't do camel case for both. What do you suggest?

This has got to be a duplicate I've seen this question so many times. — JonH, Aug 25 '11 at 12:03

score 5 · Answer 1 · answered Aug 25 '11 at 12:02

5

You can have same name. To have it more elegant, you can have:

this.framesX = framesX; // the first one is private class member
this.framesY = framesY;

answered Aug 25 '11 at 12:02

Shadow The GPT Wizard

66,030
26
140
208

Only the first one is a private class member (as suggested with the comment), therefore i assume the declaration of framesY is omitted on the posted code (and this.framesY would not compile) – Aug 25 '11 at 12:04
I don't think he was trying to assign the parameter to itself. – Shadow The GPT Wizard Aug 25 '11 at 12:27

score 3 · Answer 2 · answered Aug 25 '11 at 12:02

3

I generally do:

private int _framesX;
private int _framesY;

That makes it more clear:

public void SetAnimation(int framesX, int framesY)
{
    _framesX = framesX;
    _framesY = framesY;
}

answered Aug 25 '11 at 12:02

Matthew Abbott

60,571
9
104
129

I think it's more appropriate to put the underscores on the parameter names. – Rag Aug 25 '11 at 12:03
I like this more rather than using this. – pokoko222 Aug 25 '11 at 12:03
1

Yes, but the naming convention for C# recommends not using underscores. – Darren Young Aug 25 '11 at 12:03
Yes they say don't use underscores. – pokoko222 Aug 25 '11 at 12:04
@All - why are you making this complex, why change the name of something when you know for sure that it makes sense not to change it. Use `this`, it's very much legit and the right way. – JonH Aug 25 '11 at 12:06
They recommended it originally, but a lot of their code goes against this very thing. – Matthew Abbott Aug 25 '11 at 12:07

score 1 · Answer 3 · answered Aug 25 '11 at 12:03

1

This really depends on the company you work at. Basically a naming convention is a team rule and for example, Resharper allows you to add a team convention

answered Aug 25 '11 at 12:03

Yurii Hohan

4,021
4
40
54

score 0 · Answer 4 · answered Aug 25 '11 at 12:02

0

You can name it the same, but if referring to the private member you have to use

this.framesX;

So for example;

this.framesX = framesX;

answered Aug 25 '11 at 12:02

score 0 · Answer 5 · answered Aug 25 '11 at 12:03

0

I normaly name my private fields (are there others ;) ) with a '_' prefixed. For some people this is a smell others do the same - I guess it's a matter of taste.

answered Aug 25 '11 at 12:03

Random Dev

51,810
9
92
119

score 0 · Answer 6 · answered Aug 25 '11 at 12:03

0

I use _framesX for marking private fields.

answered Aug 25 '11 at 12:03

Alexander Schmidt

5,631
4
39
79

score 0 · Answer 7 · answered Aug 25 '11 at 12:03

0

You could go with the "_" prefix for private members or use "this.framesX" or both "this._framesX".

I'd say it depents on what your team is using.

answered Aug 25 '11 at 12:03

score 0 · Answer 8 · answered Aug 25 '11 at 12:03

Your code is fine, you might need to specify this thought. Well thats how I name my Fields and parameters mostly.

public void SetAnimation(int framesX, int framesY)
{
    this.framesX = framesX; // the first one is private class member
    this.framesY = framesY;
}

score 0 · Answer 9 · answered Aug 25 '11 at 12:04

private variables should start with lowercase. so you've got that right.

you can make yr code work by using 'this' keyword to refer back to the instantiated object.

public void SetAnimation(int framesX, int framesY)
{
    this.framesX = framesX; // the first one is private class member
    this.framesY = framesY;
}

score 0 · Answer 10 · answered Aug 25 '11 at 12:06

0

I have a tendency to use only properties starting with a capital, and define the getter and setter public or private

public int FramesX { public get; private set; }
public int FramesY { get; set; }

answered Aug 25 '11 at 12:06

Bazzz

26,427
12
52
69

C# naming convention for private members

10 Answers10