string.substring() in Javascript

Question

const removeParenth = function (str) {
  // your code here - don't forget to return a string!
  let start;
  let finish;
  for (let i in str) {
    if (str[i] === '(') {
      start = i;
    }
    if (str[i] === ')') {
      finish = i;
    }
  }
  //   console.log(start, finish);
  //   console.log(str);
  let omitStr = str.substring(start, finish + 1);
  console.log(omitStr);
  return str.replace(omitStr, "");
};

console.log(removeParenth('ido(not)liketocode'));

I'm trying to slice the '(not)' part from the input string, but somehow the 'omitStr' gives me '(not)liketocode' instead of '(not)'.

Anyone knows why this happens?

You can also use regular expressions to get the same result: `'ido(not)liketocode'.replace(/\([^\(\)]*\)/g, '');` You can find explanations about this regex here: https://regexr.com/6kdt9 — pierreavn, Apr 26 '22 at 20:02

score 0 · Answer 1 · answered Apr 26 '22 at 19:57

Because you are summing string and number so it gives you uncorrect result. You can change this line finish = parseInt(i);

const removeParenth = function (str) {
  // your code here - don't forget to return a string!
  let start;
  let finish;
  for ( let i in str) {
      if (str[i] === '(') {
          start = parseInt(i);
      }
      if (str[i] === ')') {
          finish = parseInt(i);
      }
  }
//   console.log(start, finish);
//   console.log(str);
  let omitStr = str.substring(start, finish+1);
  console.log(omitStr);
  return str.replace(omitStr, "");
};

console.log(removeParenth('ido(not)liketocode'));

string.substring() in Javascript

1 Answers1