python functions and if statements

Question

user_input_num = int(input("please select a number between 0 - 100 !"))
def jokes(moon,ocean,construction,tooth,circus):
        moon = print(("Did you hear about the first restaurant to open on the moon? \n It had great food, but no atmosphere."))
        ocean = print(("What did one ocean say to the other ocean? \n Nothing, it just waved."))
        construction = print(("Do you want to hear a construction joke? \n Sorry, I’m still working on it."))
        tooth = print(("What do dentists call their x-rays? \n Tooth pics!"))
        circus = print(("Did you hear about the fire at the circus? \n It was in tents!"))

        if (user_input_num > 0 and  user_input_num < 21):
            jokes(moon)

        elif (user_input_num > 21 and  user_input_num < 41):
            jokes(ocean)

        elif (user_input_num > 41 and  user_input_num < 61):
            jokes(construction)

        elif (user_input_num > 61 and  user_input_num < 81):
            jokes(tooth)

        elif (user_input_num > 81 and  user_input_num < 101):
            jokes(circus)

        else: print("Error number not within specified range")

user should be able to input number between 1-100 and a joke will be returned , joke does not print help please

The `jokes()` function should take the `user_input_num` as an argument, not `moon,ocean,construction,tooth,circus` — ddejohn, Apr 28 '22 at 02:22

James Lin · Answer 1 · 2022-04-28T02:39:33.460

need to be like this

def jokes(user_input_num):
        moon = "Did you hear about the first restaurant to open on the moon? \n It had great food, but no atmosphere."
        ocean = "What did one ocean say to the other ocean? \n Nothing, it just waved.")
        construction = "Do you want to hear a construction joke? \n Sorry, I’m still working on it."

        if (user_input_num > 0 and  user_input_num < 21):
            print(moon)
    ....

then call your jokes method like

user_input_num = int(input("please select a number between 0 - 100 !"))
jokes(user_input_num)

Side note:

You can also use if 0 < user_input_num < 21 in your condition for better readability
I was trying to think of a more elegant approach by using dict but looks like if-else is the best way dealing with ranges, something to read before going to sleep https://stackoverflow.com/a/45075450/342553

user3167419 · Answer 2 · 2022-04-28T02:37:28.327

your indents is misplaced...just remove them, and use print directly

user_input_num = int(input("please select a number between 0 - 100 !"))       

if (user_input_num > 0 and  user_input_num < 21):
    print("Did you hear about the first restaurant to open on the moon? \n It had great food, but no atmosphere.")
elif (user_input_num > 21 and  user_input_num < 41):
    print("What did one ocean say to the other ocean? \n Nothing, it just waved.")
elif (user_input_num > 41 and  user_input_num < 61):
    print("Do you want to hear a construction joke? \n Sorry, I’m still working on it.")
elif (user_input_num > 61 and  user_input_num < 81):
    print("What do dentists call their x-rays? \n Tooth pics!")
elif (user_input_num > 81 and  user_input_num < 101):
    print("Did you hear about the fire at the circus? \n It was in tents!")   
else: print("Error number not within specified range")

score 0 · Answer 3 · answered Apr 28 '22 at 02:24

You have to call the function to make it execute the code inside it. I suggest modifying the parameters to be user_input_num so it makes more sense and runnable.

user_input_num = int(input("please select a number between 0 - 100 !"))
def jokes(user_input_num):
        moon = print(("Did you hear about the first restaurant to open on the moon? \n It had great food, but no atmosphere."))
        ocean = print(("What did one ocean say to the other ocean? \n Nothing, it just waved."))
        construction = print(("Do you want to hear a construction joke? \n Sorry, I’m still working on it."))
        tooth = print(("What do dentists call their x-rays? \n Tooth pics!"))
        circus = print(("Did you hear about the fire at the circus? \n It was in tents!"))

        if (user_input_num > 0 and  user_input_num < 21):
            jokes(moon)

        elif (user_input_num > 21 and  user_input_num < 41):
            jokes(ocean)

        elif (user_input_num > 41 and  user_input_num < 61):
            jokes(construction)

        elif (user_input_num > 61 and  user_input_num < 81):
            jokes(tooth)

        elif (user_input_num > 81 and  user_input_num < 101):
            jokes(circus)

        else: print("Error number not within specified range")
jokes(user_input_num)

score 0 · Answer 4 · answered Apr 28 '22 at 02:44

The simple way, where you don't need to use variables (e.g. moon, ocean) to reference what to print.

def jokes(user_input_num):
    if (0 < user_input_num  < 21):
        print(("Did you hear about the first restaurant to open on the moon? \n It had great food, but no atmosphere."))
    elif (21 < user_input_num < 41):
        print(("What did one ocean say to the other ocean? \n Nothing, it just waved."))
    elif (41 < user_input_num < 61):
        print(("Do you want to hear a construction joke? \n Sorry, I’m still working on it."))
    elif (61 < user_input_num < 81):
        print(("What do dentists call their x-rays? \n Tooth pics!"))
    elif (81 < user_input_num < 101):
        print(("Did you hear about the fire at the circus? \n It was in tents!"))
    else: print("Error number not within specified range")

user_input_num = jokes(int(input("please select a number between 0 - 100 !")))

or the dictionary way, which is similar to what you are doing, just make sure the keywords (e.g. moon, ocean) is a key in dictionary, not a variable.

def jokes(keyword):
    joke = {
        "moon":"Did you hear about the first restaurant to open on the moon? \n It had great food, but no atmosphere.",
        "ocean":"What did one ocean say to the other ocean? \n Nothing, it just waved.",
        "construction":"Do you want to hear a construction joke? \n Sorry, I’m still working on it.",
        "tooth":"What do dentists call their x-rays? \n Tooth pics!",
        "circus":"Did you hear about the fire at the circus? \n It was in tents!"
    }
    print(joke[keyword])

user_input_num = int(input("please select a number between 0 - 100 !"))

if (user_input_num > 0 and  user_input_num < 21):
    jokes("moon")
elif (user_input_num > 21 and  user_input_num < 41):
    jokes("ocean")
elif (user_input_num > 41 and  user_input_num < 61):
    jokes("construction")
elif (user_input_num > 61 and  user_input_num < 81):
    jokes("tooth")
elif (user_input_num > 81 and  user_input_num < 101):
    jokes("circus")
else: print("Error number not within specified range")

Btw, nice jokes.

python functions and if statements

4 Answers4