Rookie over here... Need assistance with a Python code conclusion

Question

Complete this function to return either "Hello, [name]!" or "Hello there!" based on the input

def say_hello(name):
    name = "Hello there!"

    assert name != "Hello there!"
    # You can print to STDOUT for debugging like you normally would
    print(name)

    # but you need to return the value in order to complete the challenge  
    return "" # TODO: return the correct value

I've tried a couple of things but run into errors such as assertion error... I have completed practice test similar to this before but I'm just drawing a blank here. Any help with the proper code and how you came to it would be greatly appreciated.

Show us your best attempt instead of just todos. As a hint `name or "there!"` is a pretty good start. — tdelaney, May 04 '22 at 23:32
What do you mean by "based on the input"? When should it return `Hello there!`? — Barmar, May 04 '22 at 23:35
The `assert` will _always_ fail. I don't understand this code. — John Gordon, May 04 '22 at 23:41
this was my garbage attempt to solve what I figured was an easy question. Will try and post slightly harder material! — Grade-a-j, May 05 '22 at 00:08

notoriousjere · Accepted Answer · 2022-05-04T23:36:30.113

0

This will populate the name if one is given and it is not empty ("" evaluates to False)

def say_hello(name=None):
    return f"Hello, {name}!" if name else "Hello there!"

edited May 04 '22 at 23:36

answered May 04 '22 at 23:35

notoriousjere

153
9

Why not use `"there"` as the default value? – Barmar May 04 '22 at 23:35
@Barmar does it really matter? this question is so simple. – notoriousjere May 04 '22 at 23:51
1

good lord this was driving me a little crazy and you came thru with the simplicity!! – Grade-a-j May 05 '22 at 00:02

score 0 · Answer 2 · answered May 04 '22 at 23:36

assert doesn't make much sense here. You just want to choose one of two return values based on the value of name. You can start with adding a default value to the name parameter which gives the caller the option of not supplying a name at all and then do a simple truth test.

def say_hello(name=None):
    if name:
        return f"Hello, {name}"
    else:
        return "Hello there!"

Rookie over here... Need assistance with a Python code conclusion

2 Answers2