omiting number sign using regex in java script not working

Question

I have written a simple code in a .js file (in Zend framework, but I dont think it matters)

var location = "localhost:8080/mymodule/id/1#";
location.replace(/\#/g, "");
alert(location.valueOf());
return;

but I dont know why I can not see the result I want. I get my page url and want to omit all number signs appears in it. but the code above does nothing. please help

score 6 · Answer 1 · answered Aug 27 '11 at 11:47

location is a bad name to use for a variable since it collides with the window.location variable used for the actual browser page location.

If you change location to loc in your above code, and then also add loc = in front of the loc.replace() call (since replace() doesn't modify the input, but instead returns the new version), your code works.

ipr101 · Answer 2 · 2011-08-27T11:58:47.530

6

replace will not change the value of the original string, you need to assign the result to a new variable -

var newString = location.replace(/#/g, "");
alert(newString);

Demo - http://jsfiddle.net/5H5uZ/

edited Aug 27 '11 at 11:58

answered Aug 27 '11 at 11:47

ipr101

24,096
8
59
61

Why are you escaping the `#`? – tchrist Aug 27 '11 at 11:53
I'd just copied from the original question, removed now. Thanks for pointing it out. – ipr101 Aug 27 '11 at 11:59

score 2 · Answer 3 · answered Aug 27 '11 at 11:55

2

It can be done in one line. This is the result you look for?

alert("localhost:8080/mymodule/id/1#".replace(/#/g,'')); 
  //=> alerts 'localhost:8080/mymodule/id/1'

answered Aug 27 '11 at 11:55

KooiInc

119,216
31
141
177

omiting number sign using regex in java script not working

3 Answers3