Number format exception when returning values from database(JPA)

Question

I want to fill a simple h:datatable tag with some values from a database. But i get an exception and i cant find what is the reason:

java.lang.NumberFormatException: For input string: "url"

This is how i create the datatable:

<h:form>        
    <h:dataTable value="#{managementBB.retrieveRecords()}" var="record">
    <h:column>
        <f:facet name="header">URL</f:facet>
        #{record.url}
    </h:column>
    <h:column>
        <f:facet name="header">Submition date</f:facet>
        #{record.submitionDate}
    </h:column>
    <h:column>
        <f:facet name="header">Unacceptable</f:facet>
        #{record.unnaceptableContent}
    </h:column>
    <h:column>
        <f:facet name="header">Option</f:facet>
        Something
    </h:column>
    </h:dataTable>
</h:form>

This is the backing bean behind this page:

@Named("managementBB")
@SessionScoped
public class ManagementBB implements Serializable{

    @EJB
    private ILinkManagerEJB linkManagerEJB;

    public List<Record> retrieveRecords() {     
            return linkManagerEJB.retrieveRecords();
    }
}

This is the EJB that accesses the database to get the data:

@Stateless(name = "ejbs/LinkManagerEJB")
public class LinkManagerEJB implements ILinkManagerEJB {

    @PersistenceContext
    private EntityManager entityManager;

    public List<Record> retrieveRecords() {
        Query allRecords = entityManager.createNamedQuery("allrecordinfo");      
        return (List<Record>) allRecords.getResultList();
    }
}

And finally this is the JPA entity that represents a row in the database:

@Entity
@NamedQueries({@NamedQuery(name = "allrecordinfo",
   query = "SELECT r.url, r.submitionDate, r.unnaceptableContent FROM Record r")})
public class Record {

    @Id
    @GeneratedValue
    private long id;
    @Column(nullable = false)
    private String url;
    @Column(nullable = false)
    private String submitionDate;
    @Column(nullable = false)
    private boolean unnaceptableContent;

    //Get set methods ...
}

As you see it looks simple, and I've done this before but now I am confused, I don't know why is not working. Could you help me find my error?

Note: I am pretty confident that the query syntax is ok (I tested it in eclipse's scrapbook)

score 3 · Answer 1 · edited Jun 20 '20 at 09:12

3

java.lang.NumberFormatException: For input string: "url"
 #{record.url}

This suggests that Record is actually an Object[] because it is expecting an integer index like so

#{record[0]}

Indeed, your query is wrong, it is not selecting the Record, but only individual fields, which would return a List<Object[]> with the individual fields instead of List<Record>. The cast (which would have generated a warning) doesn't prevent/change that.

edited Jun 20 '20 at 09:12

Community

1
1

answered Aug 27 '11 at 18:41

BalusC

1,082,665
372
3,610
3,555

Ups, i thing i understand, so that means i need something like `Select * from Record` – javing Aug 27 '11 at 18:43
While I typed my answer I saw that Ammar already posted an answer with the right syntax (I upvoted it as well), so I omitted it to not disturb him. I was just trying to explain the underlying cause so that the exception could be understood. – BalusC Aug 27 '11 at 18:45
I just fixed it now. It was a silly mistake, its not the first time it hapend to me :) Thanks. – javing Aug 27 '11 at 18:47

score 2 · Accepted Answer · answered Aug 27 '11 at 18:40

2

The query is not correct.

@NamedQueries({ @NamedQuery(name = "allrecordinfo", query = "SELECT r FROM Record r") })
@Entity
public class Record {
}

answered Aug 27 '11 at 18:40

Ammar

2,387
1
14
12

Thats correct thanks Ammar. I will accept your answer as in 10 mins. :) – javing Aug 27 '11 at 18:48

score 1 · Answer 3 · answered Aug 27 '11 at 21:11

To prevent an error like this in the future, you should use a typed query instead of a cast.

Casting the query result from a typeless query is a rather old practice (from 2006 actually) that should not be used anymore.

Some extra hints: you don't have to specify an explicit name for your EJB. Just @Stateless is enough. The same holds for the CDI bean, which will get a default name.

Then, you might want to rethink the name of the EJB's interface. The initial I is a bit frowned upon lately.

Also, it's more common to create a getter for the data you're returning from the backing bean. After that you can use a value binding (ommit the () in the EL experssion).

Finally, you may want to move the call to your EJB to an @PostConstruct method, as JSF might call your backing bean's methods many times, which will now result in a DB call every time. If you do that, your bean should also be best in view scope, but that means you either have to go from CDI beans to regular JSF managed beans, or use seam 3.

Number format exception when returning values from database(JPA)

3 Answers3

Linked