Use JSON parse instead of eval

Question

I have this string that I generate in JAVA and pass to javascript to be parsed.

This works:

var childString = '[{title: "Item 1"},{title: "Folder 2", isFolder: true,children: [{title: "Sub-item 2.1"},{title: "Sub-item 2.2"}]},{title: "Item 3"}]';
var childArray = eval(childString);

But I've read everywhere that eval == evil so i'm looking into the JSON way of parsing. I tried using JSON.parse(childString), but I got an error.

How could I do this the JSON way?

Thanks!

@naveen: Yep, the keys have to be in double quotes. Don't understand your second comment though. — Felix Kling, Aug 30 '11 at 15:29
@Felix: was mentioning that OP was using an arraqy of objects and not valid JSON — naveen, Aug 30 '11 at 15:42
possible duplicate of [JSON Data - Parsed Or 'Eval'ed](http://stackoverflow.com/questions/1143417/json-data-parsed-or-evaled) — outis, Dec 26 '11 at 09:23

score 7 · Answer 1 · answered Aug 30 '11 at 15:16

7

Your data is valid JavaScript (which is why eval works) but it is not valid JSON. For example you need to surround the name of your properties with quotes.

E.g.

'[{"title": "Item 1"} ...

You can find the JSON spec here

answered Aug 30 '11 at 15:16

Matt

43,482
6
101
102

score 3 · Answer 2 · answered Aug 30 '11 at 15:16

3

Depending on your browser, you may need to define the JSON object yourself. You can download the code for it from https://github.com/douglascrockford/JSON-js.

answered Aug 30 '11 at 15:16

FishBasketGordo

22,904
4
58
91

score 3 · Answer 3 · answered Aug 30 '11 at 15:16

3

Your JSON isn't well formed. You need double quotes on both the keys and the values.

'{"foo":"bar"}'

answered Aug 30 '11 at 15:16

zzzzBov

174,988
54
320
367

score 3 · Accepted Answer · answered Aug 30 '11 at 15:19

You can't parse it using JSON.parse because your json string is invalid. It needs to be as follows:

var childString = '[{"title": "Item 1"},{"title": "Folder 2", "isFolder": true,"children": [{"title": "Sub-item 2.1"},{"title": "Sub-item 2.2"}]},{"title": "Item 3"}]';

See here.

score 1 · Answer 5 · answered Dec 10 '12 at 21:36

1

Note: The double quotes are imperative. THIS WOULD NOT WORK:

var childString = "[{'title': 'Item 1'},{'title': 'Folder 2', 'isFolder': true,'children': [{'title': 'Sub-item 2.1'},{'title': 'Sub-item 2.2'}]},{'title': 'Item 3'}]";

answered Dec 10 '12 at 21:36

Paul V

351
3
9

The double quotes needed to be passed within the string. So you need to single quote the object '[ ..... ]' and have the double quotes internally '[ ""...""..."" ]'. – Paul V May 06 '14 at 13:17

score 1 · Answer 6 · answered Aug 30 '11 at 15:15

1

Include JSON2 in your HTML output using a script tag, and you can then use JSON.parse.

answered Aug 30 '11 at 15:15

Femi

64,273
8
118
148

score 1 · Answer 7 · answered Aug 30 '11 at 15:22

1

Ok, jsFiddle:

var childArray = JSON.parse(childString.replace(/([{, ])([a-zA-Z0-9]+):/g, '$1"$2":'));

will work, but I might still try to get valid JSON instead.

answered Aug 30 '11 at 15:22

Joe

80,724
18
127
145

Use JSON parse instead of eval

7 Answers7