0

I am able to get all other fields, but I am not sure how to map the field newItems inside the Rooms since it is an array of struct Item.

I have tried let newItem = data["newItems"] as? [Item] ?? [], but this does not seem to be working.

Room.swift

struct Room: Codable, Identifiable {
  var id: String
  var title: String
  var newItems: [Item]
  var members: [String]
}

Item.swift

struct Item: Codable, Identifiable {
  var id: String?
  var name: String
  var desc: String
  var qty: String
  var assignedTo: String
}

Auth.swift

  @Published var rooms = [Room]()

  func populateRoomList () {            
    DispatchQueue.main.async {
      Firestore.firestore().collection("rooms")
        .whereField("members", arrayContains: self.userSession!.uid)
        .addSnapshotListener { snapshot, error in                
          guard let doc = snapshot?.documents else {
            print("No Doc Found")
            return
          }
   
          self.rooms = doc.map({ docSnapshot -> Room in
            let data = docSnapshot.data()
            let docId = docSnapshot.documentID
            let title = data["title"] as? String ?? ""
            let mem = data["members"] as? [String] ?? []
            return Room(id: docId, title: title, newItems: , members: mem)
          })
        }
    }
  }

enter image description here

Peter Friese
  • 6,709
  • 31
  • 43
  • have a look at these posts to "... Map a FireBase Document to SwiftUI..." : https://stackoverflow.com/questions/38038990/firebase-converting-snapshot-value-to-objects and https://stackoverflow.com/questions/37106246/read-data-from-firebase-and-save-into-an-array-swift and https://medium.com/@nskonieczko/firebase-datasnapshot-to-swift-struct-7935ad5ec6a4 – workingdog support Ukraine Jun 19 '22 at 23:13
  • I have no idea what's wrong. My data["newItems] prints Optional({ assignedTo = none; desc = "brown eggs"; name = egg; qty = 1; }) but it won't cast. Is there any manual way of doing it? –  Jun 20 '22 at 01:50
  • After spending hours on it, I kinda worked it out by first casting it as an array of dictionaries and then creating my Item struct from it. –  Jun 20 '22 at 04:05
  • Hi @workingdogsupportUkraine - the questions you link to are a bit dated, and the Medium article is about RTDB. My blog post about Firestore and Codable is always kept up to date: https://peterfriese.dev/posts/firestore-codable-the-comprehensive-guide/ – Peter Friese Jun 20 '22 at 08:17
  • Peter Friese, agreed, your blog post is much better and worth a good read. – workingdog support Ukraine Jun 20 '22 at 13:52

1 Answers1

1

You're almost there - using Codable for your data structs is the first step.

Instead of mapping your documents manually (as you do), Codable allows you to rely on the Firestore SDK and the Swift compiler to do the heavy lifting for you. I've written a comprehensive guide about how this works and how to use it, including code snippets for fetching single documents and entire collections or queries - check it out: Mapping Firestore Data in Swift - The Comprehensive Guide.

In your case, here is a modified version of the code for your repository (I wouldn't recommend putting this code Auth.swift, as the main concern is not about auth, but fetching data):

class RoomRepository: ObservableObject {
  @Published var rooms = [Room]()
  @Published var user: User

  @Published var errorMessage: String?

  private var db = Firestore.firestore()
  private var listenerRegistration: ListenerRegistration?

  public func unsubscribe() {
    if listenerRegistration != nil {
      listenerRegistration?.remove()
      listenerRegistration = nil
    }
  }

  func subscribe() {
    if listenerRegistration == nil {
      listenerRegistration = db.collection("rooms")
        .whereField("members", arrayContains: user.uid)
        .addSnapshotListener { [weak self] (querySnapshot, error) in
          guard let documents = querySnapshot?.documents else {
            self?.errorMessage = "No documents in 'colors' collection"
            return
          }

          self.rooms = documents.compactMap { queryDocumentSnapshot in
            let result = Result { try queryDocumentSnapshot.data(as: Room.self) }

            switch result {
            case .success(let room):
              if let room = room {
                // A Room value was successfully initialized from the DocumentSnapshot.
                self?.errorMessage = nil
                return room
              } else {
                // A nil value was successfully initialized from the DocumentSnapshot,
                // or the DocumentSnapshot was nil.
                self?.errorMessage = "Document doesn't exist."
                return nil
              }
            case .failure(let error):
              // A Room value could not be initialized from the DocumentSnapshot.
              self?.errorMessage = error.localizedDescription
              return nil
            }
          }
        }
    }
  }
}

A couple of notes:

  1. You wrapped the code for fetching data from Firestore in DispatchQueue.main.async. Instead of wrapping the entire block, you should only wrap the code that accessed the UI (i.e. the code inside the completion block).
  2. Since Firestore returns on the main thread anyway, do no not need to switch back to the main thread yourself. See this thread for more details about this.

Codable is a very powerful tool, have a look at my blog post to learn about all the different ways you can use it to map data - I cover a wide range of use cases and data types. If you find anything is missing, let me know (by filing a feature request here) and I will add it. There's also a GitHub repo with all the source code: https://github.com/peterfriese/Swift-Firestore-Guide

Peter Friese
  • 6,709
  • 31
  • 43