How to status from string list using c#

Question

I am working on an application where I have a list of statuses like Submitted, Approved, and Rejected. In my scenario when all the statutes are Approved then I have to return Approved but if there is a single record that is Rejected then will return Rejected. If there is a record with the status Submitted and the other two are Approved then return Submitted. I have implemented a simple check base logic but I need to make it better with best practices and more generic.

List<string> statuses = new List<string>() { "Approved", "Approved", "Approved" };
var res = statuses.Where(x => x == "Approved").ToList();
    
if (res.Count() == statuses.Count())
{
    Console.WriteLine("Approved");
}

if (res.Where(x => x == "Rejected").Count() > 0)
{
    Console.WriteLine("Rejected");
}
else
{
    Console.WriteLine("Submitted");
}

How can I achieve this and improve my logic?

Any should be helpful like in `bool notApproved = statuses.Any(x => x != "Approved");` — Ralf, Jun 29 '22 at 10:52
Besides the correct anwers below, I would like to highlight that your code has a bug. In your list named res, there are only appoved items, asking the res list for rejected items will always return an empty list. That line should ask the statuses list instead. — 0lli.rocks, Jun 29 '22 at 11:05
@0lli.rocks yes that is correct but that also might be the case. — Muhammad Kamran, Jun 29 '22 at 11:08

score 3 · Answer 1 · answered Jun 29 '22 at 10:54

List<string> statuses = new List<string>() { "Approved", "Approved", "Submitted" };

if (statuses.All(x => x == "Approved"))
{
    System.Console.WriteLine("Approved");
}
else
{
    if (statuses.Any(x => x == "Rejected"))
    {
        System.Console.WriteLine("Rejected");
    }
    else
    {
        System.Console.WriteLine("Submitted");
    }
}

score 2 · Answer 2 · answered Jun 29 '22 at 10:52

2

You could simplify the logic like this:

Have a function to work out the status:

private static string GetStatus(List<string> statuses) 
{
        if (statuses.Any(x => x == "Rejected")) return "Rejected";
        if (statuses.All(x => x == "Approved")) return "Approved";
        return "Submitted";
}

Call it like this:

Console.WriteLine(GetStatus(statuses));

answered Jun 29 '22 at 10:52

Donal

31,121
10
63
72

How about If I define an extra list which contain all the three statuses is there any way to compare for status check. – Muhammad Kamran Jun 29 '22 at 10:59
@MuhammadKamran sure you can do something like this, check if any in List 1 match any in List 2.: List1.Any(x => List2.Any(y => y == x)); – Donal Jun 29 '22 at 11:02

score 1 · Accepted Answer · answered Jun 29 '22 at 10:58

1

So we have a clear order

Approved < Submitted < Rejected

and we want to find out a maximum:

if we have at least one Rejected we return Rejected
if we don't have Rejected but at least one Submitted then we return Submitted
we return Approved if and only if all the items are Approved

This can be written as

var result = statuses.MaxBy(item => Array.IndexOf(
  new [] { "Approved", "Submitted", "Rejected" }, item));

answered Jun 29 '22 at 10:58

Dmitry Bychenko

180,369
20
160
215

How should I know if it contains Submitted and Rejected status – Muhammad Kamran Jun 29 '22 at 11:02
@Muhammad Kamran: if `statuses` contains `Rejected` then `Array.IndexOf` returns `2` (index of `"Rejected"`) for this `item == "Rejected"`; which is maximum and that's why we get `"Rejected"` – Dmitry Bychenko Jun 29 '22 at 11:05
Yes I have debug it got it. – Muhammad Kamran Jun 29 '22 at 11:07

How to status from string list using c#

3 Answers3