if else statement not working(nodejs,html)

Question

I have this code that will get the year from a html form and im trying to set an argument for it but the else statement never seem to execute. Any clue as to why?

exports.printyear = function(request, response) {
        let form = new formi.IncomingForm();
        form.parse(request, function(error, field, file) {
            let year = field.year;
            let currenturl = "";
            console.log("YEAR");
            console.log(year);
            if (year === 2007 | 2008 | 2009) {
                currenturl = "websiteurl" + year + ".xml";
            } else {
                currenturl = "websiteurl" + year + ".json";
            }
            console.log(currenturl);
            response.end();
        });

`year===2007|2008|2009` won't work how you expect. You need to test `year` against each value _separately_ — evolutionxbox, Jul 26 '22 at 13:25
`if (year===2007|2008|2009)` thats not how `if` statements work. You need `if(year == 2007 || year == 2008 || year == 2009){...}` — Jamiec, Jul 26 '22 at 13:26
You could be fancy and use an array: `if ([2007, 2008, 2009].includes(year)) {...}`. — Andy, Jul 26 '22 at 13:31

score 2 · Accepted Answer · answered Jul 26 '22 at 13:26

2

The right way of using or in conditions is to separate them.

Change

if (year===2007|2008|2009) {

To

if (year===2007 || year===2008 || year===2009) {

answered Jul 26 '22 at 13:26

Tamas Szoke

5,426
4
24
39

Gregoire Ducharme · Answer 2 · 2022-07-26T13:47:59.227

0

The issues seems to be this line:

if (year===2007|2008|2009) {

You need to compare each value one by one like this:

if (year===2007||year===2008||year===2009)

What you're doing right now is a bitwise operator |

(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR)

edited Jul 26 '22 at 13:47

answered Jul 26 '22 at 13:25

Gregoire Ducharme

1,095
12
24

score 0 · Answer 3 · answered Jul 26 '22 at 13:28

Unless I'm missing something, the syntax in the if statement is is not valid JS. Try the following:

if (year === 2007 || year === 2008 || year === 2009) {
    currenturl = "websiteurl" + year + ".xml";
} else {
    currenturl = "websiteurl" + year + ".json";
}

if else statement not working(nodejs,html)

3 Answers3

Change

To