0

So i have alot a code running on one button press. Update excel file , sent mails to a list of mail adresses, reload excel into datagridview , clear listbox and textboxes, write a log text line inside a text file, disable some UI.

Now i have split the reloading excel file and writing log on a extra OK press from the user. Which helps a little. But still makes the program go unresponsive on sending mail and updating excel.

I don't think the updating excel is the issue. Its like 1 specific cell in about an average of 10 rows.

But the issue seems to be the mail sending. It awaits confirmation if mail has been sent and the mail server here is slow.

My mail sending code is this

SmtpClient smtpClient = new SmtpClient();
MailMessage message = new MailMessage();

If (System.IO.File.Exists(emailfile)
{
String[] Lines = System.IO.File.ReadAllLines(emailfile);
   Foreach (string line in Lines)
      message.To.Add(line);
}

Else
 {  System.IO.File.WriteAllText(emailfile,"");
TextWriter Email = new StreamWriter(emailfile, true);
Email.Writeline("foo@email.com");
Email.close();
 }

try
{
MailAdress fromAddress = new MailAddress("goo@email.com","order");
smtpClient.Host "";
smtpClient.Port xx;
smtpClient.credentials = ("""");
smtpClient.DeliveryMethod = SmtpDeliveryMethod.Network;
message.From = fromAddress;
message.Subject = "";
message.IsBodyHtml = True;
message.Body = Mybody();
message.DeliveryNotificationOptions = DeliveryNotificationOptions.OnFailure;
smtpClient.Send(message);
}

Catch (exception)
{
 MessageBox.Show("mail error");
}

I have read something about SendAsyc, I have also read something about task.run or task.factory.startnew There is also backgroundworker.

I don't understand which one i should use and how to implement it.

I do need the UI to wait(but not go unresponsive) for the mail to be sent and give a message box when it is done or failed.

Duivelbryan
  • 17
  • 7
  • 1
    "*I don't understand which one i should use...*" All three options are fine. "*...and how to implement it.*" [Here](https://stackoverflow.com/a/2200793/87698) is a code example I wrote a while ago for using a background worker to do lengthy work. Does that help? – Heinzi Aug 22 '22 at 13:26
  • 2
    Here is a good place to start to learn more about async programming in c# https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/async/ – jhambright Aug 22 '22 at 13:28
  • 1
    There are many way to program async calls. You should keep in mind that every code called from the UI (buttons) is running under the UI thread. If this code takes some time, it will block the UI. Depends on the framework you're using, but you can probably use async - await which is one of the easiest way – Bisjob Aug 22 '22 at 13:45

1 Answers1

1

Using Async code would look something like

public async void OnButtonPress(){
  try{
     await SendEmail();
  }
  Catch (exception)
  {
     MessageBox.Show("mail error");
  }
}
private async Task SendEmail(){
   ...
   await smtpClient.SendMailAsync(...);
}

This is fairly safe, since all of your code will run on the UI-thread. A potential downside is that some *Async-methods are liars, and do significant work on the UI thread, so may not fully resolve the blocking issue. This approach also do not work with CPU-intensive code. So you may need to test this to see if it solves your problem.

The other alternative is to run the code synchronously on a background thread

public async void OnButtonPress(){
  try{
     await Task.Run(SendEmail);
  }
  Catch (exception)
  {
     MessageBox.Show("mail error");
  }
}
private void SendEmail(){
   // do work
}

The largest downside with this method is that the SendEmail method cannot access any UI-objects, and other shared data structures may need to be protected by locks. I would recommend reading up a bit about thread safety before doing anything involving multiple threads.

JonasH
  • 28,608
  • 2
  • 10
  • 23