non static method 'update' should not be called statically. How I can solve this error?

Question

This is my function. and i'm getting error in it.Kindly help me solve this error.and also tell me why I'm getting this error.

  public function update(Request $request)
        {
            $id = $request->id;
            $grade = Grade::find($id);
    
            $grade = $request->validate([
                'title' => 'required|string',
                'slig' => 'string',
                'description' => 'string',
            ]);
    
            $grade = Grade::update($grade);
    
            return [
                'staus' => 'success',
                'grade' => $grade,
            ];
        }

You need to create an object of that class and then call that function. — Sachin, Sep 01 '22 at 08:25
For next time; When you get an error message, always start by search on the error message and you will, in most cases, find plenty of questions/answers. — M. Eriksson, Sep 01 '22 at 08:34

jeremykenedy · Answer 1 · 2022-09-01T08:34:49.297

0

Create an instance first. But I don't think that's the real issue.

$newGrade = (new Grade() )->update($grade);

return [
    'status' => 'success',
    'grade'  => $newGrade,
];

Try changing your method to as follows:

    $grade = Grade::findOrFail($request->id);

    $validatedData = $request->validate([
        'title' => 'required|string',
        'slig' => 'string',
        'description' => 'string',
    ]);

    $grade->update($validatedData);

    return [
        'status' => 'success',
        'grade' => $grade,
    ];

edited Sep 01 '22 at 08:34

answered Sep 01 '22 at 08:26

jeremykenedy

4,150
1
17
25

You can drop`$g` variable with `$newGrade = (new Grade() )->update($grade);` – Marcin Orlowski Sep 01 '22 at 08:29

Thinus · Answer 2 · 2022-09-01T08:38:59.547

Instantiating a new class

You are trying to access the class as if it were a Facade. You could possibly change the use statement at the top to prepend Facade. The Laravel way of instantiating the class would either be through dependancy injection where you pass the class to the method parameters

public function update(Grade $grade, Request $request) {
    // do stuff with $grade->update()
}

or use Real Time Facades or use it the way JeremyKenedy suggested but by using the app() helper function.

app()->make(Grade::class)

score 0 · Answer 3 · answered Sep 01 '22 at 08:47

Your update function is wrong. please try it.

  public function update(Request $request)
    {
        $id = $request->id;
        $grade = Grade::find($id);

        $grade = $request->validate([
            'title' => 'required|string',
            'slig' => 'string',
            'description' => 'string',
        ]);

        $grade->update([ 
           'title' => $request->title,
           'slig' => $request->slig,
           'description' => $request->description
        ]);

        return [
            'staus' => 'success',
            'grade' => $grade,
        ];
    }

non static method 'update' should not be called statically. How I can solve this error?

3 Answers3

Instantiating a new class