AddToRolesAsync causing Invalid Operation the connection is closed

Question

I am getting the oddest of errors when I attempt to assign roles to user the role is their in the db fine.

But the function used to assign roles is causing an exception

public static async Task<IdentityResult> 
AssignRoles(IServiceProvider services,ApplicationUser user, 
            string email, string[] roles)
{
    IdentityResult result = new IdentityResult();            
    UserManager<ApplicationUser> _userManager = 
    services.GetService<UserManager<ApplicationUser>>();            
    result = await _userManager.AddToRolesAsync(user, roles);
    
    return result;
 }

The exception that I am getting is after the AddToRolesAsync is called

Invalid Operation the connection is closed

Code I use to call above

public async static void CreateParent(IServiceProvider serviceProvider)
{
  var context = new DBContext();// 
      serviceProvider.GetService<DBContext>();

  string[] roles = new string[] { "Parent" };

  foreach (string role in roles)
  {
    var roleStore = new RoleStore<IdentityRole>(context);
    if (!context.Roles.Any(r => r.Name == role))
    {
        await roleStore.CreateAsync(new IdentityRole(role));
    }
}
        
var user = new ApplicationUser
{
    FirstName = "Parent",
    LastName = "Two",
    Email = "parenttwo@apps-mobileapp.com",
    NormalizedEmail ="PARENTTWO@APPS-MOBILEAPP.COM",
    UserName = "parenttwo@apps-MOBILEAPP.com",
    NormalizedUserName = "PARENTTWO@APPS-MOBILEAPP.COM",
    PhoneNumber = "+111111111111",
    EmailConfirmed = true,
    PhoneNumberConfirmed = true,
    SecurityStamp = Guid.NewGuid().ToString("D")
};

var db = new DBContext();
if (!db.Users.Any(u => u.UserName == user.UserName))
{
    var password = new PasswordHasher<ApplicationUser>();
    var hashed = password.HashPassword(user, "Test12345!");
    user.PasswordHash = hashed;
    
    var userStore = new UserStore<ApplicationUser>(context);
    var result = await userStore.CreateAsync(user);
}

await AssignRoles(serviceProvider,user, user.Email, roles);

await db.SaveChangesAsync();

}

But its the AddToRolesAsync it fails with the error mentioned above, I am calling it form the startup class as such?

public void Configure(IApplicationBuilder app, 
                      IWebHostEnvironment env,IServiceProvider 
                      service)
{
   SampleData.CreateParent(service);
}

`async void` is a problem. Asynchronous methods should be awaited. — Svyatoslav Danyliv, Sep 05 '22 at 20:13
try commenting out the line `new DBContext()` and uncommenting the reference to the `ServiceProvider`'s version. It seems to be a lifetime issue. — Shai Cohen, Sep 05 '22 at 20:14
No, it is not awaited, it should be `await SampleData.CreateParent(service);`. Actually problem that you are trying to call async method in synchronous code. Good [source](https://stackoverflow.com/a/40344759/10646316) — Svyatoslav Danyliv, Sep 05 '22 at 20:22
But user managers need to be async there for the seed function must be also ! so how is it a probelm — c-sharp-and-swiftui-devni, Sep 05 '22 at 20:24
It seems to be a lifetime issue. Take a look at the line `new DBContext()`. Comment out that and uncomment the reference to the ServiceProvider's version. — Shai Cohen, Sep 05 '22 at 20:49
You could add the db context to dependecy injection to be singlenton. I'm not so sure, but it looks like the problem is that when you do a savechanges the lifetime (as mention the @ShaiCohen) is failling — Heitor Ribeiro, Sep 05 '22 at 21:21
In combination with your answers I got what the issue was it was how I was declaring it in the startup file — c-sharp-and-swiftui-devni, Sep 05 '22 at 21:32

AddToRolesAsync causing Invalid Operation the connection is closed

0 Answers0