How do I get the maximum of a dictionary list?

Question

Hello guys I'm new in python and I'm trying to get the item with the highest kcalorie from a dictionary list but the outout isn't correct can I know what's the problem

maxkcal = int()
kcaldict = { 'udon':300,'salad':150,'gyudon':500,'pasta':450}
print("The menu is:")
for key,value in kcaldict.items():
    print(key,value)
    maxkcal = max([max(kcaldict.values()) for dict in kcaldict])
print("The food with the highest calorie on the menu is :" ,key, maxkcal,"(Kcal)")

the output is :

The menu is:
udon 300
salad 150
gyudon 500
pasta 450
The food with the highest calorie on the menu is : pasta 500 (Kcal)

but it's supposed to be gyudon 500 not pasta

What do you mean by "dictionary list"? `kcaldict` is just a dictionary, there's no list. — Barmar, Oct 04 '22 at 06:03
`kcaldict.values())` doesn't make use of `dict`. You're just calculating the same maximum every time through the list comprehension. It also doesn't depend on `key` and `value`. — Barmar, Oct 04 '22 at 06:06

score 0 · Accepted Answer · edited Oct 05 '22 at 03:51

0

You can try using max:

kcaldict = { 'udon':300,'salad':150,'gyudon':500,'pasta':450}
max_key, max_val = max(kcaldict.items(), key=lambda x: x[1])
print("The food with the highest calorie on the menu is :" ,max_key, max_val,"(Kcal)")

As pointed out in the comments, I have changed the code a little bit now it will work fine.

Your code should be like this:

import sys
maxkcal = -sys.maxsize
maxkcal_key = None
kcaldict = { 'udon':300,'salad':150,'gyudon':500,'pasta':450}
print("The menu is:")
for key,value in kcaldict.items():
    print(key,value)
    if value > maxkcal:
        maxkcal = value
        max_key = key
print("The food with the highest calorie on the menu is :" ,max_key, maxkcal,"(Kcal)")

edited Oct 05 '22 at 03:51

Sunderam Dubey

1
11
20
40

answered Oct 04 '22 at 06:02

Deepak Tripathi

3,175
1
8
21

Didn't work.. are you sure? or can you fix my code so I can know my mistake? – Hazem Majeek Oct 04 '22 at 06:05
Let me fix your code as well but this will work I have checked it at my end. – Deepak Tripathi Oct 04 '22 at 06:06
Yeah it works thanks I inserted it to my code incorrectly tha'ts why it didn't work but can you fix mine anyway please? – Hazem Majeek Oct 04 '22 at 06:09
@HazemMajeek Now check I have updated your code as well – Deepak Tripathi Oct 04 '22 at 06:09
Thanks! Probably I should search out the sys thing because it's my first time seeing this I thought it can be solved in a simpler way. Thanks again for making my first experience on Stackoverflow good – Hazem Majeek Oct 04 '22 at 06:13
`max(kcaldict, key=lambda x: x[1])` is just plain wrong. It just so happens to return `'gyudon'` with the OP's given input only because its second character happens to be the largest lexicographically among the keys. – blhsing Oct 04 '22 at 06:17
@blhsing you are correct. Now I have updated the code. – Deepak Tripathi Oct 04 '22 at 06:37

How do I get the maximum of a dictionary list?

1 Answers1