Why is the JSON file not being read?

Question

I wrote a class with fields. Then I need an init method to initialize the fields of the class. But it throws an error Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: C. Path '', line 0, position 0.

public class Valera
{
    private int health; 
    private int mana; 
    private int happiness; 
    private int fatigue; 
    private bool dead; 

    public void init()
    {
        var v = JsonConvert.DeserializeObject<Valera>(@"C:\Users\User\RiderProjects\MarginalValera\MarginalValera\Properties\characteristics.json");
        Console.WriteLine(v?.dead);
    }
}

JSON object:

{
  "health" : "100",
  "mana": "50",
  "happiness": "0",
  "fatigue": "50",
  "dead": "false"
}

`JsonConvert.DeserializeObject` takes a JSON string, not a path to a file. you'll have to read the file then pass that to `JsonConvert.DeserializeObject` — Daniel A. White, Oct 11 '22 at 14:57
@DanielA.White - It's not a typo... It's a fundamental misunderstanding of what arguments the API is expecting... It is probably a dupe though — ScottishTapWater, Oct 11 '22 at 15:11

ScottishTapWater · Answer 1 · 2022-10-11T15:12:03.977

2

You need to read the file first then deserialise it:

string rawJson = File.ReadAllText(@"C:\Users\User\RiderProjects\MarginalValera\MarginalValera\Properties\characteristics.json");

Valera obj = JsonConvert.DeserializeObject<Valera>(rawJson);

edited Oct 11 '22 at 15:12

answered Oct 11 '22 at 14:59

ScottishTapWater

3,656
4
38
81

Thank you! But why do I still have all obj fields null, and not those that are written in json? – Alica Smith Oct 11 '22 at 15:22
@AlicaSmith - Probably because your json is wrong, numbers shouldn't be quoted and neither should booleans – ScottishTapWater Oct 11 '22 at 15:24

score 0 · Answer 2 · answered Oct 11 '22 at 16:55

you have to fix the class, you need public properties with {get; set;}

public class Valera
{
    public int health { get;set; }
    // ... and so on
}

or if for some reason you need the private fields, you will have to create a constructor

public class Valera
{
    private int health;
    private int mana;
    private int happiness;
    private int fatigue;
    private bool dead;

    public Valera(int health,int mana,int happines,int fatique,bool dead){

        this.health = health;
        this.mana = mana;
        this.happiness = happiness;
        this.fatigue =       fatigue;
        this.dead =               dead;
    }
}

also fix the code

string rawJson = File.ReadAllText(@"C:\Users\User\RiderProjects\MarginalValera\MarginalValera\Properties\characteristics.json");

Valera obj = JsonConvert.DeserializeObject<Valera>(rawJson);

Why is the JSON file not being read?

2 Answers2