Trying to script RemotePowershellEnabled $false to all users except for a couple in specific admin groups

Question

I am trying to set up a powershell script to automatically run a command to get a list of all user accounts that have "Remotepowershellenabled" $True then take that list and compare it to 2 admin groups. After that I want it to set all of the user accounts that are not a part of the 2 admin accounts to then set that option to $false. When I get to this part of my script the new variable is not populating with anything. I know for a fact that there are users listed in the variable $UserswithRemotePS that are not in the $DomainAdmin variable.

$UsersNotDA = $UserswithRemotePS | where {$_.samaccountname -inotin $DomainAdmin}

I put this script together by looking at a couple of other similar scripts so I clearly missed something. Any help would be greatly appreciated.

$DomainAdmins = (Get-ADGroupMember -Identity "Domain Admins").samaccountname|out-string
$Exchangeadmins = (Get-ADGroupMember -Identity "ExchangeAdmins").samaccountname|out-string

Get-PSSession|Remove-PSSession

$ExchangePSSession = New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri http://ExchangeServer/PowerShell/ -Authentication Kerberos

$UserswithRemotePS = (Invoke-Command -Session (Get-PSSession) {Get-User -ResultSize Unlimited -Filter 'RemotePowerShellEnabled -eq $true'}).samaccountname|out-string
 
$UsersNotDA = $UserswithRemotePS | where {$_.samaccountname -notin $DomainAdmin}

Answer 1

There are some typos in your code like $DomainAdmins where later you use -notin $DomainAdmin (note the lack of the s in there), but most notably is the mistake you make by destroying your arrays using Out-String.

This will make the arrays become single strings where operator -notin is meant to search for items not contained in an array of things.

Also, by using single-quotes here: 'RemotePowerShellEnabled -eq $true', $true will not be evaluated as you would like, because now the value is the exact string '$true'. For this, you need double-quotes.

Try

# get arrays of SamAccountNames (so do not pipe to Out-String!!)
$DomainAdmins   = (Get-ADGroupMember -Identity "Domain Admins").SamAccountName
$Exchangeadmins = (Get-ADGroupMember -Identity "ExchangeAdmins").SamAccountName

Get-PSSession|Remove-PSSession

$ExchangePSSession = New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri http://ExchangeServer/PowerShell/ -Authentication Kerberos

$UserswithRemotePS = Invoke-Command -Session $ExchangePSSession -ScriptBlock {
    (Get-User -ResultSize Unlimited -Filter "RemotePowerShellEnabled -eq $true").SamAccountName
}

$UsersNotDA = $UserswithRemotePS | Where-Object {$_.SamAccountName -notin $DomainAdmins}