7

I'm reading host information from a text file and pass it to an ssh command: The text file contains the host, user and password for the ssh command

while read LINE
do
    R_USER=$(echo $LINE | cut -d ',' -f 1)                  
    R_HOST=$(echo $LINE | cut -d ',' -f 2)                                  
    PY_SCRIPT=$(echo $LINE | cut -d ',' -f 4)               

    ssh $R_USER@$R_HOST 'touch /home/user/file_name.txt'

done </path_name/file_name

As it turns out the while loop is only executed once even if the host text file contains multiple host information. When I remove the ssh command the while loop gets executed as much as there are lines in the host information text file.

Not sure why this is so. Any information on this?

Roland

that other guy
  • 116,971
  • 11
  • 170
  • 194
roland
  • 587
  • 2
  • 9
  • 17
  • 1
    By the by, you can avoid all that hideous `cut`ting by changing the Internal Field Separator to a comma temporarily, and `read`ing straight into your variables: `IFS=','; while read R_USER R_HOST dhummi PY_SCRIPT rest; do`... – tripleee Sep 14 '11 at 06:20

2 Answers2

21

The default standard input handling of ssh drains the remaining line from the while loop.

To avoid this problem, alter where the problematic command reads standard input from. If no standard input need be passed to the command, read standard input from the special /dev/null device:

while read LINE
  do
    R_USER=$(echo $LINE | cut -d ',' -f 1)                  
    R_HOST=$(echo $LINE | cut -d ',' -f 2)                                  
    PY_SCRIPT=$(echo $LINE | cut -d ',' -f 4)               

    ssh $R_USER@$R_HOST 'touch /home/user/file_name.txt' < /dev/null

done </path_name/file_name

Or alternatively, try using ssh -n which will prevent ssh from reading from standard input. For instance:

ssh -n $R_USER@$R_HOST 'touch /home/user/file_name.txt'
Jugal Shah
  • 3,621
  • 1
  • 24
  • 35
1

If the file is white space separated

host1 user password
host2 user password

then a simple read loop:

while read -r Server User Password
do
   /usr/bin/ssh -n $User@$Server touch /home/user/file_name.txt
done </path/to/file.list

But you will be prompted for the password. You cannot pass the "Password" to ssh so I'd suggest storing passwordless ssh-keys and placing them on each host for the user you are connecting as. If you are running this command from a script you can ssh as these users on each host by placing your public key in the user's ~/.ssh/authorized_keys (or authorized_keys2) file. If you have the ssh-copy-id command you could do this by:

ssh-copy-id user@hostname

which would copy YOUR ssh-key to their authorized_keys file so you could then ssh as them. This is assuming you have permission but then again you have their password so what permission do you need?

johnnyB
  • 796
  • 7
  • 15
  • Nice simple read loop I had trouble with separating server and user in my while loop – MKT May 04 '13 at 14:20