How do I properly destroy an Apache Commons DBCP Pool in Java?

Question

I would like to use a PoolingDataSource as my connection pool (API at: http://commons.apache.org/dbcp/apidocs/org/apache/commons/dbcp/PoolingDataSource.html), but I don't know what to do with the pool when I no longer need it. What if I want to connect to a new database and don't need the connections in the old pool anymore? There is no close method on the pool.

score 3 · Accepted Answer · answered Sep 16 '11 at 19:48

You don't necessarily need to kill this pool to create a new one.

You can manage the connections in it using the maxIdle, timeBetweenEvictionRunsMillis and minEvictableIdleTimeMillis parameters (see here) to ensure idle connections get closed in a reasonable time.

Or you can configure a GenericObjectPool with those parameters programatically and use when creating your PoolingDataSource. That has a close() method if you want to force it.

score 2 · Answer 2 · edited May 23 '17 at 12:34

2

Sorry for not answering your question directly, but may I recommend not using DBCP? It has had a number of serious problems, which other libraries learned from and improved upon.

There are much better pools out there.

edited May 23 '17 at 12:34

Community

1
1

answered Sep 16 '11 at 19:50

erickson

265,237
58
395
493

1

While fairly accurate; it should be noted DBCP has been actively maintained since this answer was provided. – Brett Ryan May 09 '16 at 07:27

score 1 · Answer 3 · answered Sep 16 '11 at 19:46

1

What kind of pool are you using? If you're using the AbandonedObjectPool, then that's a subclass of Commons Pool's GenericObjectPool, which has a close() method.

answered Sep 16 '11 at 19:46

Tom Anderson

46,189
17
92
133

I am using a PoolingDataSource as I said in the question. I also linked to it's API docs. – Buttons840 Sep 26 '11 at 14:45

How do I properly destroy an Apache Commons DBCP Pool in Java?

3 Answers3