UIViewController retain count problem

Question

I am creating a new UIViewController with the below code

GameViewController *temp = [[GameViewController alloc] initWithNibName:@"GameViewController" bundle:nil];
NSLog(@"retain count%d", [temp retainCount]);
temp.backgroundMusic = backgroundMusic;
self.gameView = temp;
[temp release];     
[self presentModalViewController:gameView animated:YES];                
[gameView release];

but when I look at retain counts, my temp view controller returns 4.

How this is possible?? Because it is 4, when I dismiss the view controller I cant remove it from memory and my game is going on playing. (I can see the effects of AI playing).

[gameView release] should be self.gameView=nil; (depending if you have declared the gameView property with retain) — AndersK, Sep 20 '11 at 09:55

score 6 · Answer 1 · answered Sep 20 '11 at 11:53

6

Never use retainCount, it does not work the way you think it does.

If you need to see where retains, releases and autoreleases occur for an object use instruments:

Run in instruments, in Allocations set "Record reference counts" on on (you have to stop recording to set the option). Cause the picker to run, stop recording, search for there ivar (datePickerView), drill down and you will be able to see where all retains, releases and autoreleases occurred.

Example screenshot

answered Sep 20 '11 at 11:53

zaph

111,848
21
189
228

1

Finally, someone with a demonstration of using the Allocations instrument to track retain counts! Thank you! – bbum Sep 20 '11 at 14:49

score 4 · Answer 2 · edited May 23 '17 at 10:24

4

"You should never use retainCount". Here is a very good description, why to not: stackoverflow

edited May 23 '17 at 10:24

Community

1
1

answered Sep 20 '11 at 09:54

Infinite Possibilities

7,415
13
55
118

What I got is that the returned retain counts are not correct. So what do you think is my problem?? why after I dismiss a viewcontroller, I can hear the movement musics of characters in my main menu?? – Ömer Baykal Sep 20 '11 at 09:58
You should stop your music in the `viewWillDisappear` method. Don't try to solve this problem with the `retainCount` method. – Infinite Possibilities Sep 20 '11 at 09:59
It is not only the music thing. My dealloc method also does not work and musics playing means the AI functions are countinuing to work?? – Ömer Baykal Sep 20 '11 at 10:02
tell me, how your gameView property is declared. – Infinite Possibilities Sep 20 '11 at 10:21

Jose Luis · Answer 3 · 2011-09-20T11:57:56.767

I advise you never using retainCount because it usually gives false information about the actual retaincount of your object!!!!

Just follow the appropiate memory management practices!!!! It's very simple really, just follow the NARC principle, release only the objects that have these words: New Alloc Retain Copy. NARC! :)

I strongly advise you using the memory leaks tool from instruments that tells you which objects were not released and which objects where released and you are trying to access.

Saran · Answer 4 · 2011-09-20T15:17:59.523

1

In GameViewController have you released your background music as

- (void)viewDidLoad{
   //Other nils
   self.backgroundMusic = nil;
}
- (void)dealloc{
    //Other releases
    [backgroundMusic release];
    [super dealloc];
}

edited Sep 20 '11 at 15:17

answered Sep 20 '11 at 10:20

Saran

6,274
3
39
48

@bbum sorry i left it as indicative. However, Now updated my answer. – Saran Sep 20 '11 at 15:19

UIViewController retain count problem

4 Answers4

Linked