8

Probably really easy but im having trouble finding documentation online about this I have two activerecord queries in Ruby that i want to join together via an OR operator

@pro = Project.where(:manager_user_id => current_user.id )
@proa = Project.where(:account_manager => current_user.id)

im new to ruby but tried this myself using ||

@pro = Project.where(:manager_user_id => current_user.id || :account_manager => current_user.id)

this didnt work, So 1. id like to know how to actually do this in Ruby and 2. if that person can also give me a heads up on the boolean syntax in a ruby statement like this altogether. e.g. AND,OR,XOR...

SD1990
  • 808
  • 1
  • 11
  • 29
  • possible duplicate of [ActiveRecord OR query](http://stackoverflow.com/questions/3639656/activerecord-or-query) – user Jul 26 '15 at 03:52

3 Answers3

13

You can't use the Hash syntax in this case.

Project.where("manager_user_id = ? OR account_manager = ?", current_user.id, current_user.id)
SD1990
  • 808
  • 1
  • 11
  • 29
Simone Carletti
  • 173,507
  • 49
  • 363
  • 364
  • So there is no way to express an OR condition in Arel/ActiveRecord other than building a Sql string? – Klaus Sep 21 '11 at 15:04
  • This is Arel/ActiveRecord. You're not building a SQL string. The SQL string would be `SELECT * FROM table WHERE ...` – Simone Carletti Sep 21 '11 at 15:08
2

You should take a look at the API documentation and follow conventions, too. In this case for the code that you might send to the where method.

This should work:

@projects = Project.where("manager_user_id = '#{current_user.id}' or account_manager_id = '#{current_user.id}'")

This should be safe since I'm assuming current_user's id value comes from your own app and not from an external source such as form submissions. If you are using form submitted data that you intent to use in your queries you should use placeholders so that Rails creates properly escaped SQL.

# with placeholders
@projects = Project.where(["manager_user_id = ? or account_manager_id = ?", some_value_from_form1, some_value_from_form_2])

When you pass multiple parameters to the where method (the example with placeholders), the first parameter will be treated by Rails as a template for the SQL. The remaining elements in the array will be replaced at runtime by the number of placeholders (?) you use in the first element, which is the template.

Andrés N. Robalino
  • 301
  • 2
  • 3
1

Metawhere can do OR operations, plus a lot of other nifty things.

DGM
  • 26,629
  • 7
  • 58
  • 79