Android - getResources().getIdentifier replacement

Question

In android I am looping through the database and assigning text and image:

Cursor res = myDb.getAllData();

while (res.moveToNext()) {
    Actors actor = new Actors();
    actor.setName(res.getString(1));

    String th =  res.getString(11);
    Integer thumb = this.getResources().getIdentifier(th, "drawable", "mypackage");

    actor.setThumb(R.drawable.th);
}

However Lint suggests not to use getIdentifier - Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code.

In database column I have just the image name (string). How can I replace getIdentifier?

Even if I change the DB column maybe directly to R.drawable.imagename, it is still a string and for setThumb I need a drawable.

Answer 1

The best way is Using mapOf list like This example

val iconResourceMap = mapOf(
        "icon_1" to R.drawable.icon_1,
        "icon_2" to R.drawable.icon_2,
        // Add mappings for all the icons you have
    )

    for (i in 0 until data.length()) {
        val iconName = "icon_${i + 1}"
        val iconResId = iconResourceMap[iconName] ?: 0
}

Happy coding!

Answer 2

Ok, so the only solution what I've found is here https://stackoverflow.com/a/4428288/1345089

public static int getResId(String resName, Class<?> c) {

        try {
            Field idField = c.getDeclaredField(resName);
            return idField.getInt(idField);
        } catch (Exception e) {
            e.printStackTrace();
            return -1;
        } 
    }

and then just calling:

int resID = getResId("icon", R.drawable.class);

This works very well, however some users reports, that after installing the app from Play store (not my app, but any with this method implemented and proguard enabled), after a while it will start throwing NoSuchFieldException, as more resources are mapped to the same class/field.

It can be caused by proguard but not sure. The solution is then to put the old way getResources().getIdentifier to the exception part of code.

Answer 3

You can try this approach:

• Rename your resources as follow: ressourceName00 ressourceName01 ressourceName02 .... and so on,

then use the methode below:

for (int i = 0; i < RessourceQtt; i++) {
        Uri path1 = Uri.parse("android.resource://yourPackage Directories/drawable/ressourceName0" + i);

        list.add(new CarouselItem(String.valueOf(path1)));
    }

Answer 4

You can try this my code three way

// Show message and quit
    Application app = cordova.getActivity().getApplication();
    String package_name = app.getPackageName();
    Resources resources = app.getResources();
    String message = resources.getString(resources.getIdentifier("message", "string", package_name));
    String label = resources.getString(resources.getIdentifier("label", "string", package_name));
    this.alert(message, label);

set icon like that

private int getIconResId() {
Context context = getApplicationContext();
Resources res = context.getResources();
String pkgName = context.getPackageName();
int resId;
resId = res.getIdentifier("icon", "drawable", pkgName);
return resId;

}

this is also

//set icon image
final String prefix = "ic_";
String icon_id = prefix + cursor.getString(cursor.getColumnIndex(WeatherEntry.COLUMN_ICON));
Resources res = mContext.getResources();
int resourceId = res.getIdentifier(icon_id, "drawable", mContext.getPackageName());
viewHolder.imgIcon.setImageResource(resourceId);

I hope this code help for you.

public static int getIcId(String resN, Class<?> c) {
try {
    Field idF = c.getDeclaredField(resN);
    return idF.getInt(idF);
} catch (Exception e) {
    throw new RuntimeException("No resource ID found for: "
            + resN+ " / " + c, e);
}}

Answer 5

In Kotlin, due to getidentifier and Typed array

instate of this code:

resources.getIdentifier("l$i", "drawable", packageName)

must do two step:

1- Make a array list in res/values/arrays.xml

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <array name="icons">
        <item>@drawable/home</item>
        <item>@drawable/settings</item>
        <item>@drawable/logout</item>
    </array>
 
</resources>

2- Call in an Activity

val icons: TypedArray = resources.obtainTypedArray(R.array.icons)
val drawable: Drawable = icons.getDrawable(0)

Points:

I) if you want call ID as Int use this way :

icons.getResourceId(i,0) //i is a counter

II) if you use it in Recycle View so must add

 icons.recycle()