ProcessBuilder does not stop

Question

I am trying to decode an mp3 file to a wav file by using the ProcessBuilder class under Linux. For some reason the process does not stop so that I have to cancel it manually.

Could somebody give me a hint on this. I think that the quoted code is very easy to reproduce:

import java.io.*;

public class Test {
 public static void main(String[] args) {
     try {
         Process lameProcess = new ProcessBuilder("lame", "--decode", "test.mp3", "-").start();
         InputStream is = lameProcess.getInputStream();
         FileOutputStream fileOutput = new FileOutputStream("test.wav");
         DataOutputStream dataOutput = new DataOutputStream(fileOutput);


         byte[] buf = new byte[32 * 1024];
         int nRead = 0;
         int counter = 0;
         while((nRead = is.read(buf)) != -1) {
             dataOutput.write(buf, 0, buf.length);
         }

         is.close();
         fileOutput.close();

     }
     catch (Exception e) {
         e.printStackTrace();
     }
 }
}

Output of jstack

"main" prio=10 tid=0x0000000002588800 nid=0x247a runnable [0x00007f17e2761000]
   java.lang.Thread.State: RUNNABLE
    at java.io.FileInputStream.readBytes(Native Method)
    at java.io.FileInputStream.read(FileInputStream.java:236)
    at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
    at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
    - locked <0x00000000eb5b1660> (a java.io.BufferedInputStream)
    at java.io.FilterInputStream.read(FilterInputStream.java:107)
    at Test.main(Test.java:17)

Shouldn't at one point the `waitFor()` method be called on the `Process` object? — biziclop, Sep 26 '11 at 21:29
Where does it hang? Get a thread dump with `jstack ` or `kill -3 `. — Philipp Reichart, Sep 26 '11 at 21:30
Looks like you're hung in the `read()` call. Did your external process terminate? — Jim Garrison, Sep 26 '11 at 21:56

score 10 · Accepted Answer · answered Sep 26 '11 at 22:55

10

You need to drain both the output (via getInputStream()) and error (via getErrorStream()) streams of the process, otherwise it may block.

Quoting the Process documentation:

Because some native platforms only provide limited buffer size for standard input and output streams, failure to promptly write the input stream or read the output stream of the subprocess may cause the subprocess to block, and even deadlock.

(which applies to both the error and output streams)

You'll probably need to drain each stream in different threads because each may block when it has no data.

answered Sep 26 '11 at 22:55

prunge

22,460
3
73
80

Or you could use [ProcessBuilder.redirectErrorStream()](http://download.oracle.com/javase/6/docs/api/java/lang/ProcessBuilder.html#redirectErrorStream(boolean)) to combine the streams into one to make life easier. – Jon7 Sep 26 '11 at 23:01
+1. My advise is to use `java.util.concurrent` to spawn a new thread and pass the interested `InputStream` into new thread for accumulating. You can do it in one line using Apache IO commons: `IOUtils.toString(inputStream, YOUR_CONSOLE_CHARSET);` – dma_k Sep 26 '11 at 23:12
1

@Jon7 redirectErrorStream() is probably not a good idea in this particular case - the output stream is used as WAVE output and having error messages mixed in there would corrupt the WAV file. – prunge Sep 27 '11 at 02:37

score 3 · Answer 2 · answered Sep 26 '11 at 23:03

3

It might be a lot easier for you to use a LAME Java wrapper like LAMEOnJ. That way you avoid spawning off processes and you can just interact with lame as if it were a Java library.

answered Sep 26 '11 at 23:03

Jon7

7,165
2
33
39

ProcessBuilder does not stop

2 Answers2

Linked