0

so im making cs50 course and in this week problem set, I ran into a problem with this conditional

bool vote(string name)
{
    // TODO
    for (int i = 0; i < 2; i++)
    {
        if (name == candidates[i].name)
        {
            candidates[i].votes++;
            printf("ok!\n");
            return true;
        }
    }
    return false;
}

the "print ok" its just so I know if true has returned or not.

the conditional its not returning true even if the candidates[i].name == name, already tested if they are equals by using printf in "string name" and in "candidates[0].name".

this is the full code:

#include <cs50.h>
#include <stdio.h>
#include <string.h>

// Max number of candidates
#define MAX 9

// Candidates have name and vote count
typedef struct
{
    string name;
    int votes;
}
candidate;

// Array of candidates
candidate candidates[MAX];
int array_len = sizeof(candidates) / sizeof(candidates[0]);


// Number of candidates
int candidate_count;

// Function prototypes
bool vote(string name);
void print_winner(void);

int main(int argc, string argv[])
{
    // Check for invalid usage
    if (argc < 2)
    {
        printf("Usage: plurality [candidate ...]\n");
        return 1;
    }

    // Populate array of candidates
    candidate_count = argc - 1;
    if (candidate_count > MAX)
    {
        printf("Maximum number of candidates is %i\n", MAX);
        return 2;
    }
    for (int i = 0; i < candidate_count; i++)
    {
        candidates[i].name = argv[i + 1];
        candidates[i].votes = 0;
        printf("%s\n", candidates[i].name);
    }

    int voter_count = get_int("Number of voters: ");

    // Loop over all voters
    for (int i = 0; i < voter_count; i++)
    {
        string name = get_string("Vote: ");

        // Check for invalid vote
        if (!vote(name))
        {
            printf("Invalid vote.\n");
        }
    }

    // Display winner of election
    print_winner();
}

// Update vote totals given a new vote
bool vote(string name)
{
    // TODO
    for (int i = 0; i < 2; i++)
    {
        if (name == candidates[i].name)
        {
            candidates[i].votes++;
            printf("ok!");
            return true;
        }
    }
    return false;
}

I want it to return true if equal.

0 Answers0