Fire comboBox SelectedIndexChanged only from user click

Question

I wrote a method to handle a comboBox's SelectedIndexChanged event.

In the constructor I populated the comboBox, and this activated my event-handling method. Which I don't want since nobody clicked on the comboBox.

Is there an easy way to get the comboBox not to fire the event unless the user clicked it?

If that is not possible, is there a way to disconnect the event to the method temporarily? Could I just set "my_combo.SelectedIndexChanged = null" and then create a new System.EventHandler?

Or I guess I could create some kind of boolean member variable that I can switch on or off and put a branch check in my method. That seems like a kludge, though.

This is probably an easy question, but google didn't seem to have any ready answers. Google can be like a person who talks too much because sometimes the best thing is to stop listening and get things done. — micahhoover, Sep 29 '11 at 20:10

Sandy · Answer 1 · 2013-04-22T06:59:48.920

39

I have done it a lot number of times. Solution1: Delete EventHandler from designer. Populate the combobox and then set EventHandler.

Combo1.SelectedIndexChanged += new EventHandler Combo1_SelectedIndexChanged;

But it will work only if you are populating the combobox once.If you are doing it for many number of times, then you may be in a mess.

Solution2: Its my preference and I use it regularily. Change your selection change event as:

private void cb1_SelectedIndexChanged(object sender, EventArgs e)
{
   ComboBox cb = (ComboBox)sender;
   if(!cb.Focused)
   {
      return;
   }
   // Here is your Code for selection change
}

So now the event will be fired only if its in focus. Hope you were looking for the same. Hope it Helps

edited Apr 22 '13 at 06:59

answered Sep 30 '11 at 07:14

Sandy

11,332
27
76
122

2

Up vote for creativity. I've used this solution on other frameworks (Qt), but it ended up leading to some bad side effects. Was still the best solution in that case. Here, probably not. – micahhoover Sep 30 '11 at 13:22
Actually, the event must be triggered whether the component is **not** focused. Just invert the boolean condition... ;-) – cesarse Apr 18 '13 at 22:02
1

Greate solution! if you change the casting to Control its generic for any type of control.. – Amit Lipman Jul 26 '18 at 14:46

score 37 · Answer 2 · edited May 23 '17 at 10:29

37

Not sure if this is any use now but I found this answer, which seems cleaner to me.

From the MSDN Library - ComboBox.SelectionChangeCommitted Event

"SelectionChangeCommitted is raised only when the user changes the combo box selection. Do not use SelectedIndexChanged or SelectedValueChanged to capture user changes, because those events are also raised when the selection changes programmatically."

edited May 23 '17 at 10:29

Community

1
1

answered Nov 19 '12 at 11:17

user692942

16,398
7
76
175

4

This is by far the simplest method. It does what the user wants without having to create & destroy event handlers. It also encourages better programming practices, where using a boolean to synchronize events in spite of other events is dangerous. – psyklopz Mar 13 '13 at 19:00
4

I also agree. This is simple and works effectively. The accepted answer did not work for me, and it does seem messy compared to this solution. – Cody Feb 17 '14 at 04:30
When it fires, the `comboBox.Text` has its old value. – Ahmad Dec 19 '15 at 06:17
@Ahmad what does that mean? Can't say I've had any problems with it myself. – user692942 Aug 30 '17 at 09:17
1

This is nice. I searched for something like "SelectedIndexChanging" and the consensus seemed to be that it was not an option. Well, here it is. – codingcoding Jul 15 '18 at 20:49

score 9 · Accepted Answer · edited Oct 30 '14 at 00:25

9

You can use both methods You proposed:

use boolean variable

detach event method, populate combobox, attach event method like this

my_combo.SelectedIndexChanged -= my_Combo_SelectedIndexChanged;
populateCombo();

my_combo.SelectedIndexChanged += my_Combo_SelectedIndexChanged;

my_Combo_SelectedIndexChanged is the name of method you attached to the event.

edited Oct 30 '14 at 00:25

user692942

16,398
7
76
175

answered Sep 29 '11 at 20:20

Filip Popović

2,637
3
18
18

score 4 · Answer 4 · answered Jul 23 '13 at 02:41

4

I would use control.ContainsFocus instead of creating other bool. The caveat here is that you have to make sure the user has focus on that control. Either by key or mouse.

if(combo.ContainsFocus){ MyEventLogic();}

answered Jul 23 '13 at 02:41

TatiOverflow

1,071
2
16
23

1

This is not a good idea. This is not bullet proof. What if you call for example a function from a timer which reloads the combobox while the combobox STILL has the focus from a previous click? – Elmue Aug 22 '18 at 23:53

score 2 · Answer 5 · answered Sep 29 '11 at 20:18

2

Solution: If you're populating combobox with static values only ones, just populate them and after subscribe to event from code. Do not use WinForms Designer to subscribe to it.
If it's not possible during loading can:

a) define a boolean variable bool loading, set it to true before you begin to populate combo with data, and in event handler check

if(loading) return;

b) Unsubsribe from event:

If subscription was:

comboBox.SelectedIndexChanged += delegate(...);

Unsubscription before you begin load data is:

comboBox.SelectedIndexChanged -= delegate(...);

As loading of data finished, subscribe again.

answered Sep 29 '11 at 20:18

Tigran

61,654
8
86
123

1

You seemed to understand the question since you sort of returned it back to me, but echoing the question is not exactly what I was looking for here. No up vote. – micahhoover Sep 30 '11 at 13:32
@micahhoover: honestly don't see any difference between mine answer and those ones I see in the list. I didn't ask you any question, but just provide with couple of solutions I think can be suitable to you. By the way, no prob, good luck. – Tigran Sep 30 '11 at 13:52

Fire comboBox SelectedIndexChanged only from user click

5 Answers5