2

I was trying to transform the following nested media query CSS with premailer.

<style type="text/css">
    @media (prefers-color-scheme: dark) {

      .textPrimary {
        color: #E2E2E2 !important;
      }

      @media (max-width: 630px) {

        body,
        .footerContainer {
          background-color: #1E1E1E !important;
        }
      }
    }
</style>

I'm having trouble with followig error:

html = instance.transform(html, pretty_print=False)
  
File "/usr/local/lib/python3.10/dist-packages/premailer/premailer.py", line 414, in transform
    style.text = self._css_rules_to_string(these_leftover)
  File "/usr/local/lib/python3.10/dist-packages/premailer/premailer.py", line 683, in _css_rules_to_string
    for key in rule.style.keys():
AttributeError: 'CSSMediaRule' object has no attribute 'style'. Did you mean: '_type'?

My premailer version is 3.10.0 and I've tried with both python 3.8 and 3.10. No luck :(

Rijoanul Hasan Shanto
  • 383
  • 3
  • 10

1 Answers1

1

It appears that premailer currently does not handle nested media queries. This error can be avoided if you can un-nest the queries like so

<style type="text/css">
    @media (prefers-color-scheme: dark) {
          .textPrimary {
            color: #E2E2E2 !important;
          }
      }

      @media (max-width: 630px) and (prefers-color-scheme: dark) {
        body,
        .footerContainer {
          background-color: #1E1E1E !important;
          }
      }
</style>

However, as far as I know premailer "ignores" media queries anyway. Media queries get left in the <style> header and everything else gets inlined.

Matt M
  • 691
  • 2
  • 6
  • 17
  • 1
    Appreciate your help here. Unfortunately in my scenario, I've to avoid unnesting the media queries (left them intact as they come from the source as I already have some more pre and postprocessing tasks). But I think I'll have to end up doing some cleanup if I've no more options left as you mentioned. Exploring their package to see if I can contribute and make a PR to resolve this issue. Thanks again. – Rijoanul Hasan Shanto May 03 '23 at 19:26