11

I have two source files:

Source FIle 1 (assembler.c):

#include "parser.c"
int main() {
    parse_file("test.txt");
    return 0;
}

Source File 2 (parser.c):

void parse_file(char *config_file);
void parse_file(char *src_file) {
    // Function here
}

For some reason, when compiling it is giving me the following error: duplicate symbol _parse_file in ./parser.o and ./assembler.o for architecture x86_64

Why is it giving me a duplicate symbol for parse_file? I am just calling the function here... No?

darksky
  • 20,411
  • 61
  • 165
  • 254

4 Answers4

13

First off, including source files is a bad practice in C programming. Normally, the current translation unit should consist of one source file and a number of included header files.

What happens in your case is that you have two copies of the parse_file function, one in each translation unit. When parser.c is compiled to an object file, it has its own parse_file function, and assembler.c also has its own.

It is the linker that complains (not the compiler) when given two object files as an input, each of which contains its own definition of parse_file.

You should restructure your project like this:

parser.h

void parse_file(char *);

parser.c

void parse_file(char *src_file) {
    // Function here
}

assembler.c

/* note that the header file is included here */
#include "parser.h"

int main (void) {
    parse_file("test.txt");
    return 0;
}
Blagovest Buyukliev
  • 42,498
  • 14
  • 94
  • 130
8

You're including the parser.c file, which means all the code that is in that file will be "copied" to assembler.c file. That means that the entire contents of parser.c will be compiled when the compiler is compiling parser.c, and then it'll be compiled again when the compiler is compiling assembler.c

That's what headers are for.
In the header you can put only the declarations, so you can include it without creating the same symbols again in a different translation unit.

so you can just create a parser.h containing just the declaration of the function:

void parse_file(char *config_file);

then in your assembler.c you include just the header:

#include "parser.h" //include the header, not the implementation
int main() {
    parse_file("test.txt");
    return 0;
}
filipe
  • 3,370
  • 1
  • 16
  • 22
  • 1
    You definitely want a "parser.h" for your function prototype, and any type definitions. You also want a "guard", for example "#ifndef PARSER_H #define PARSER_H ... #endif /* PARSER_H */ – paulsm4 Oct 03 '11 at 18:19
  • PS: filipe (and a few moments later, Blagovest Buyukliev) are giving you the "solution". David Heffernan explains WHY the solution is necessary. PPS: Don't forget the "#ifndef" guards ;)! You might also want to add "extern "C" {}". – paulsm4 Oct 03 '11 at 18:23
  • Yes yes I am aware of that. I completely forgot about that because I haven't done C in almost a year. I know what I'm supposed to do. Thank you! – darksky Oct 03 '11 at 20:22
3

You are including the .c file which contains the definition of the function parse_file. Thus it is defined twice, once in each translation unit, which is not allowed.

David Heffernan
  • 601,492
  • 42
  • 1,072
  • 1,490
2

As other answers state, including the source means the file will be copied to parser.c and will be defined there as well in the original place (assembler.c). To solve this, either create a header file with your prototype:

parser.h

void parse_file(char *config_file);

And include that file:

assembler.c

#include "parser.h"
int main() {
    parse_file("test.txt");
    return 0;
}

Or remove the include and provide a clue to the function:

int main() {
    void parse_file(char *);
    parse_file("test.txt");
    return 0;
}

Or even simply remove the include at al. Not good practice, as the compiler (without information on a function) will consider its returned value is an integer and may cause other warnings.

sidyll
  • 57,726
  • 14
  • 108
  • 151