Calling a class method in python

Question

I'm looking to call a method in python from a different class like so:

class foo():
    def bar(name):
        return 'hello %s' % name

def hello(name):
    a = foo().bar(name)
    return a

Where hello('world') would return 'Hello World'. I'm aware I've done something wrong here, does anyone know what it is? I think it might be the way I'm handling the classes but I haven't got my head around it yet.

I'm using python 2.7, I think there is some syntax wrong in your code, — lostyzd, Oct 07 '11 at 16:02
We're on 2.5, not a syntax problem it was the 'self' issue as answered about 4 times below ;) — ingh.am, Oct 10 '11 at 10:26

NPE · Accepted Answer · 2011-10-07T16:07:13.260

6

In Python, non-static methods explicitly take self as their first argument.

foo.bar() either needs to be a static method:

class foo():
    @staticmethod
    def bar(name):
        return 'hello %s' % name

or has to take self as its first argument:

class foo():
    def bar(self, name):
        return 'hello %s' % name

What happens is that in your code, name gets interpreted as the self parameter (which just happens to be called something else). When you call foo().bar(name), Python tries to pass two arguments (self and name) to foo.bar(), but the method only takes one.

edited Oct 07 '11 at 16:07

answered Oct 07 '11 at 16:01

NPE

486,780
108
951
1,012

Thanks, I've only done minimal python in the past! Thanks though. – ingh.am Oct 07 '11 at 16:03

score 3 · Answer 2 · edited May 23 '17 at 12:12

3

You are missing the instance parameter in your method definition:

class foo():
    def bar(self, name):
        return 'hello %s' % name

or if you don't intend to use any part of the foo instance declare the method as a static method. There's a nice explanation between the differences here.

edited May 23 '17 at 12:12

Community

1
1

answered Oct 07 '11 at 16:00

GWW

43,129
11
115
108

score 3 · Answer 3 · answered Oct 07 '11 at 16:01

3

If it's supposed to be a class method, then you should have used the classmethod decorator and a cls argument to bar. But that makes no sense in this case, so you might have wanted a staticmethod instead.

answered Oct 07 '11 at 16:01

Fred Foo

355,277
75
744
836

3

And a `classmethod` has the class (usually called `cls`) as first parameter, so you'd have to add that too. – Oct 07 '11 at 16:02

score 3 · Answer 4 · answered Oct 07 '11 at 16:01

3

You missed out the instance parameter, usually named self:

class foo():
    def bar(self, name):
        return 'hello %s' % name

answered Oct 07 '11 at 16:01

David Heffernan

601,492
42
1,072
1,490

Calling a class method in python

4 Answers4