Core-Plot: Data labels for bar plots (2 plots, 2 sets of labels)?

Question

In my iPhone app, I have a view with two separate bar plots. Each plot has a different number of data elements. I would like to label each bar in each plot with the appropriate data, but apparently the "dataLabelForPlot" method only allows one instance of "CPTTextLayer." I would like to have the CPTTextLayer be a function of the plot and its data.

The plots have separate identifiers: "Bar Plot 1" and "Bar Plot 2." I can use the conditional if statement in the "numberOfRecordsForPlot" and "numberForPlot" methods, but it fails in the "dataLabelForPlot" method with errors saying that "label" is an unused variable. Seem very odd to me seeing that it is defined in the conditional statements.

My code looks like this:

#pragma mark Plot Data Source Methods
-(NSUInteger)numberOfRecordsForPlot:(CPTPlot *)plot {
if (plot.identifier == @"Bar Plot 1") {
    return 5; }
  else { return 4; }
}
-(NSNumber *)numberForPlot:(CPTPlot *)plot field:(NSUInteger)fieldEnum recordIndex:(NSUInteger)index {
    NSDecimalNumber *num = nil;
if (plot.identifier == @"Bar Plot 1") {
    switch ( fieldEnum ) {
        case CPTBarPlotFieldBarLocation:
            num = (NSDecimalNumber *)[NSDecimalNumber numberWithUnsignedInteger:index];
            break;
        case CPTBarPlotFieldBarTip:               
            num = (NSDecimalNumber *)[dataTemp1 objectAtIndex:index];                
            break;
    }
}
else {
    switch ( fieldEnum ) {
        case CPTBarPlotFieldBarLocation:
            num = (NSDecimalNumber *)[NSDecimalNumber numberWithUnsignedInteger:index];
            break;
        case CPTBarPlotFieldBarTip:                
            num = (NSDecimalNumber *)[dataTemp2 objectAtIndex:index];
            break;
    }
}
    return num;
}

-(CPTLayer *)dataLabelForPlot:(CPTPlot *)plot recordIndex:(NSUInteger)index {
  if (plot.identifier == @"Bar Plot 1") {
    CPTTextLayer *label = [[CPTTextLayer alloc] initWithText:[NSString stringWithFormat:@"%@", [dataTemp1 objectAtIndex:index]]]; 
    }
  else { CPTTextLayer *label = [[CPTTextLayer alloc] initWithText:[NSString stringWithFormat:@"%@", [dataTemp2 objectAtIndex:index]]]; }    
    CPTMutableTextStyle *textStyle = [label.textStyle mutableCopy];

    textStyle.color = [CPTColor redColor];
    label.textStyle = textStyle;
    [textStyle release];
return [label autorelease];
}

score 3 · Accepted Answer · answered Oct 16 '11 at 01:49

3

You've declared label inside each of the if and else blocks, making it local to those blocks. Move the variable declaration before the if statement.

CPTTextLayer *label;
if (plot.identifier == @"Bar Plot 1") {
    label = ...;
}
else {
    label = ...;
}
return [label autorelease];

answered Oct 16 '11 at 01:49

Eric Skroch

27,381
3
29
36

Amazing, Eric. I tried this earlier and had no luck. Now, with your good karma, it works. Thanks a million. – Michael Young Oct 16 '11 at 03:41

score 2 · Answer 2 · edited Nov 03 '12 at 03:16

2

plot.identifier == @"Bar Plot 1"

should be:

[plot.identifier isEqualToString: @"Bar Plot 1"

edited Nov 03 '12 at 03:16

Muthu Kumaran

17,682
5
47
70

answered Dec 30 '11 at 09:49

holeg

21
1

Core-Plot: Data labels for bar plots (2 plots, 2 sets of labels)?

2 Answers2