notifyDataSetChanged() on my adapter does not update the listview, why?

Question

I have a activity that extends listactivity, extended in this class i have a class that extends baseadapter.

now in my listactivity i have this onCreate

 /** Called when the activity is first created. */
@Override
public void onCreate(Bundle savedInstanceState) {   
    super.onCreate(savedInstanceState);
    setListAdapter(new BuildingAdapter(this));

    final ProgressDialog loading = new ProgressDialog(this);
    loading.setProgressStyle(ProgressDialog.STYLE_SPINNER);
    loading.setTitle("Laddar");
    loading.setMessage("Hämtar data från servern");
    loading.show();

    new AsyncTask<Void, Void, DataPacket.Data>()
    {
        @Override
        protected DataPacket.Data doInBackground(Void... params){
            return ServerConnection.getBuildings();
        }

        @Override
        protected void onPostExecute(DataPacket.Data param) {
            ((MainenanceApplication)getApplication()).setDataStructure(param);
            loading.dismiss();
            //((BuildingAdapter)getListAdapter()).notifyDataSetChanged();
            setListAdapter(new BuildingAdapter(BuildingSelectionActivity.this));
        }

    }.execute();
}

This works as it's supposed to, but my question is in onPostExecute I update the datastructure that the list adapter uses. Why cant I just call notifyDataSetChanged ??

If I have that line the view does not update itself, but if I use the line under where I do setListAdapter, it all works.

It could be better that you put the code that shows how you are using notifyDataSetChanged() to update the List. — Lalit Poptani, Oct 27 '11 at 17:13

score 1 · Answer 1 · answered Oct 27 '11 at 17:13

Have you tried using an AsyncTaskLoader instead of an AsyncTask for this. It's this kind of stuff that Loaders were exactly designed for. Note that even though Loaders weren't available until API-10 you can still easily access them via the android Support Pacakge from API-4 and up.

score 1 · Accepted Answer · answered Oct 27 '11 at 18:01

If the adapter is already set, setting it again will not refresh the listview. Instead first check if the listview has a adapter and then call the appropriate method.

I think its not a very good idea to create a new instance of the adapter while setting the list view. Instead, create an object.

BuildingAdapter adapter = new BuildingAdapter(context);

    if(getListView().getAdapter() == null){ //Adapter not set yet.
     setListAdapter(adapter);
    }
    else{ //Already has an adapter
    adapter.notifyDataSetChanged();
    }

score 0 · Answer 3 · answered Oct 27 '11 at 17:18

0

The only place you can update the UI is in onProgressUpdate(...);. From your doInBackground(...), call publishProgress(...).

answered Oct 27 '11 at 17:18

Raunak

6,427
9
40
52

notifyDataSetChanged() on my adapter does not update the listview, why?

3 Answers3

Linked